Skip to content

Create bucket inside Slurm cluster wrapper to control default name#1912

Merged
mr0re1 merged 2 commits into
GoogleCloudPlatform:release-candidatefrom
mr0re1:hash_it
Nov 1, 2023
Merged

Create bucket inside Slurm cluster wrapper to control default name#1912
mr0re1 merged 2 commits into
GoogleCloudPlatform:release-candidatefrom
mr0re1:hash_it

Conversation

@mr0re1

@mr0re1 mr0re1 commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

Create bucket inside Slurm cluster wrapper to set a unique name for the bucket.

@mr0re1 mr0re1 requested a review from nick-stroud October 31, 2023 23:55
@mr0re1 mr0re1 added the release-chore To not include into release notes label Nov 1, 2023
nick-stroud
nick-stroud previously approved these changes Nov 1, 2023

@nick-stroud nick-stroud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to not hold up submission. Please respond to/disposition comments.

Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/main.tf
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/main.tf
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/main.tf
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/main.tf
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/main.tf
@nick-stroud nick-stroud assigned mr0re1 and unassigned nick-stroud Nov 1, 2023
@mr0re1 mr0re1 requested a review from nick-stroud November 1, 2023 03:00
@mr0re1 mr0re1 changed the base branch from develop to release-candidate November 1, 2023 03:00
@mr0re1 mr0re1 dismissed nick-stroud’s stale review November 1, 2023 03:00

The base branch was changed.

@mr0re1 mr0re1 enabled auto-merge (squash) November 1, 2023 03:02
…udPlatform#1893)

* Add Path specialization that can be extended with cty.Path;
* Point label validation to offending value;
* Fix panic if label is not a string.

```yaml
...
vars:
  labels:
    good: "clint"
    bad: [1, 2, 3]
    ugly: true
```

```sh
Error: vars.labels must be a map of strings
24:   labels:
```

```
Error: vars.labels must be a map of strings
26:     bad: [1, 2, 3]
        ^
Error: vars.labels must be a map of strings
27:     ugly: true
        ^
```
@mr0re1 mr0re1 assigned nick-stroud and unassigned mr0re1 Nov 1, 2023
nick-stroud
nick-stroud previously approved these changes Nov 1, 2023
@nick-stroud nick-stroud assigned mr0re1 and unassigned nick-stroud Nov 1, 2023
@mr0re1 mr0re1 merged commit cab2007 into GoogleCloudPlatform:release-candidate Nov 1, 2023
@mr0re1 mr0re1 deleted the hash_it branch November 1, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants