Skip to content

Add Path specialization that can be extended with cty.Path#1893

Merged
mr0re1 merged 1 commit into
GoogleCloudPlatform:developfrom
mr0re1:ctyPathToPath
Nov 1, 2023
Merged

Add Path specialization that can be extended with cty.Path#1893
mr0re1 merged 1 commit into
GoogleCloudPlatform:developfrom
mr0re1:ctyPathToPath

Conversation

@mr0re1

@mr0re1 mr0re1 commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator
  • Add Path specialization that can be extended with cty.Path;
  • Point label validation to offending value;
  • Fix panic if label is not a string.
...
vars:
  labels:
    good: "clint"
    bad: [1, 2, 3]
    ugly: true
# Before
Error: vars.labels must be a map of strings
24:   labels:

# After
Error: vars.labels must be a map of strings
26:     bad: [1, 2, 3]
        ^
Error: vars.labels must be a map of strings
27:     ugly: true
        ^

* Add Path specialization that can be extended with cty.Path;
* Point label validation to offending value;
* Fix panic if label is not a string.

```yaml
...
vars:
  labels:
    good: "clint"
    bad: [1, 2, 3]
    ugly: true
```

```sh
Error: vars.labels must be a map of strings
24:   labels:
```

```
Error: vars.labels must be a map of strings
26:     bad: [1, 2, 3]
        ^
Error: vars.labels must be a map of strings
27:     ugly: true
        ^
```
@mr0re1 mr0re1 added the release-chore To not include into release notes label Oct 26, 2023
@mr0re1 mr0re1 requested a review from tpdownes October 26, 2023 23:08
@mr0re1 mr0re1 requested review from nick-stroud and removed request for tpdownes October 27, 2023 18:09
@mr0re1 mr0re1 assigned nick-stroud and unassigned tpdownes Oct 27, 2023
@nick-stroud nick-stroud assigned mr0re1 and unassigned nick-stroud Nov 1, 2023
@mr0re1 mr0re1 merged commit e4ede33 into GoogleCloudPlatform:develop Nov 1, 2023
@mr0re1 mr0re1 deleted the ctyPathToPath branch November 1, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants