Skip to content

core(config): unsized-images to default#11217

Merged
connorjclark merged 8 commits into
masterfrom
unsized-images-to-default
Aug 5, 2020
Merged

core(config): unsized-images to default#11217
connorjclark merged 8 commits into
masterfrom
unsized-images-to-default

Conversation

@lemcardenas

@lemcardenas lemcardenas commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

Summary

This PR moves the new unsized-images audit from experimental config to default config. Blocked until #11188 is merged.

Related Issues/PRs

#11188 #11218

@connorjclark

connorjclark commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

related #11218

Comment thread lighthouse-core/config/default-config.js Outdated
Comment thread lighthouse-core/test/results/sample_v2.json Outdated
@lemcardenas lemcardenas marked this pull request as ready for review August 5, 2020 17:39
@lemcardenas lemcardenas requested a review from a team as a code owner August 5, 2020 17:39
@lemcardenas lemcardenas requested review from connorjclark and removed request for a team August 5, 2020 17:39
radum added a commit to radum/lighthouse that referenced this pull request Aug 13, 2020
* upstream/master: (42 commits)
  docs: add Code of Conduct to project (GoogleChrome#11212)
  docs(readme): add related project: lighthouse-viewer (GoogleChrome#11250)
  core(font-size): remove deprecated DOM.getFlattenedDocument (GoogleChrome#11248)
  misc: fix typo in method name (GoogleChrome#11239)
  i18n: make double dollar validation less strict (GoogleChrome#10299)
  misc: rephrase comments to be more inclusive (GoogleChrome#11228)
  misc: tweak gcp scripts to work in google corp (GoogleChrome#11233)
  v6.2.0 (GoogleChrome#11232)
  report: correctly display CLS in budget table (GoogleChrome#11209)
  report: vertically center thumbnails (GoogleChrome#11220)
  i18n: import (GoogleChrome#11225)
  tests: istanbul ignore inpage function (GoogleChrome#11229)
  deps(snyk): update script to prune <0.0.0 and update snapshot (GoogleChrome#11223)
  core(stacks): timeout stack detection (GoogleChrome#11172)
  core(config): unsized-images to default (GoogleChrome#11217)
  core(image-elements): collect CSS sizing, ShadowRoot, & position (GoogleChrome#11188)
  core: add FormElements gatherer (GoogleChrome#11062)
  new_audit: report animations not run on compositor (GoogleChrome#11105)
  tests: update chromestatus expecatations (GoogleChrome#11221)
  deps: update dot-prop secondary dependency (GoogleChrome#11198)
  ...
lemcardenas added a commit that referenced this pull request Aug 25, 2020
patrickhulce pushed a commit that referenced this pull request Aug 26, 2020
…pact (#11317)

* Revert "core(config): unsized-images to default (#11217)"
This reverts commit 97a2375.

* Revert "core(image-elements): collect CSS sizing, ShadowRoot, & position (#11188)"
This reverts commit e0f7d51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants