core(image-elements): collect CSS sizing, ShadowRoot, & position#11188
Merged
Conversation
…tement in getNonHtmlError
brendankenny
reviewed
Aug 4, 2020
connorjclark
reviewed
Aug 4, 2020
connorjclark
approved these changes
Aug 4, 2020
connorjclark
left a comment
Collaborator
There was a problem hiding this comment.
just one nit but lgtm
Co-authored-by: Connor Clark <cjamcl@google.com>
Collaborator
|
@lemcardenas you should be able to rebase this now to get it to autoland :) |
radum
added a commit
to radum/lighthouse
that referenced
this pull request
Aug 13, 2020
* upstream/master: (42 commits) docs: add Code of Conduct to project (GoogleChrome#11212) docs(readme): add related project: lighthouse-viewer (GoogleChrome#11250) core(font-size): remove deprecated DOM.getFlattenedDocument (GoogleChrome#11248) misc: fix typo in method name (GoogleChrome#11239) i18n: make double dollar validation less strict (GoogleChrome#10299) misc: rephrase comments to be more inclusive (GoogleChrome#11228) misc: tweak gcp scripts to work in google corp (GoogleChrome#11233) v6.2.0 (GoogleChrome#11232) report: correctly display CLS in budget table (GoogleChrome#11209) report: vertically center thumbnails (GoogleChrome#11220) i18n: import (GoogleChrome#11225) tests: istanbul ignore inpage function (GoogleChrome#11229) deps(snyk): update script to prune <0.0.0 and update snapshot (GoogleChrome#11223) core(stacks): timeout stack detection (GoogleChrome#11172) core(config): unsized-images to default (GoogleChrome#11217) core(image-elements): collect CSS sizing, ShadowRoot, & position (GoogleChrome#11188) core: add FormElements gatherer (GoogleChrome#11062) new_audit: report animations not run on compositor (GoogleChrome#11105) tests: update chromestatus expecatations (GoogleChrome#11221) deps: update dot-prop secondary dependency (GoogleChrome#11198) ...
patrickhulce
pushed a commit
that referenced
this pull request
Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds new logic to collect extra information (CSS sizing, ShadowRoot info, & positioning) in the image-elements gatherer. Additionally, this PR adds a few changes to the unsized-images audit (the only audit so far that uses image-element's CSS sizing, ShadowRoot info, & positioning). There is also the addition of a smoke test within the byte-efficiency tests for the gatherer + unsized-images changes.
These changes are required before switching unsized-images to be in the default config.
Related Issues/PRs
#11115 #10085