Skip to content

docs: add Code of Conduct to project#11212

Merged
brendankenny merged 7 commits into
GoogleChrome:masterfrom
jivthesh:patch-1
Aug 12, 2020
Merged

docs: add Code of Conduct to project#11212
brendankenny merged 7 commits into
GoogleChrome:masterfrom
jivthesh:patch-1

Conversation

@jivthesh

@jivthesh jivthesh commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

Summary

@brendankenny

brendankenny commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

hi @jivthesh,

This is a good idea but we'll want to use the general Google open source code of conduct, not the Chromium one. It's provided at https://opensource.google/docs/releasing/template/CODE_OF_CONDUCT/, but as HTML, not as markdown.

Here's a version that has the raw markdown: CODE_OF_CONDUCT.md.

  • *[PROJECT NAME]* needs to be replaced with Lighthouse
  • *[PROJECT STEWARD NAME(s) AND EMAIL(s)]* replaced with Brendan Kenny (bckenny@google.com)

@jivthesh

jivthesh commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

@brendankenny shall i close this and the proper one?

@brendankenny

Copy link
Copy Markdown
Contributor

You could also edit and push this PR, but it's up to you.

@jivthesh jivthesh closed this Aug 4, 2020
@jivthesh jivthesh reopened this Aug 4, 2020
@jivthesh

jivthesh commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

@brendankenny after getting PROJECT STEWARD NAME(s) AND EMAIL(s) i will reedit this

@jivthesh

jivthesh commented Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

@brendankenny what to put in PROJECT STEWARD NAME(s) AND EMAIL(s)

@brendankenny

Copy link
Copy Markdown
Contributor

@brendankenny what to put in PROJECT STEWARD NAME(s) AND EMAIL(s)

After looking at what other Google projects are putting there, you can put me as the project steward for now and we can discuss internally how we want to handle this in the future (e.g. an external mailing list instead of a single point of contact).

I've updated the checklist above (#11212 (comment)) with the new substitution as well.

@patrickhulce

Copy link
Copy Markdown
Collaborator

Seems like a lot of projects take those responsibilities really seriously ;)

image

@vercel vercel Bot temporarily deployed to Preview August 12, 2020 07:03 Inactive
@vercel vercel Bot temporarily deployed to Preview August 12, 2020 07:03 Inactive
@vercel vercel Bot temporarily deployed to Preview August 12, 2020 07:05 Inactive
@jivthesh

Copy link
Copy Markdown
Contributor Author

@brendankenny updated please check and inform me if anything has to updated

@brendankenny brendankenny changed the title Add code of conduct to project. docs: add code-of-conduct to project Aug 12, 2020

@brendankenny brendankenny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this and thanks for your patience @jivthesh!

@brendankenny brendankenny changed the title docs: add code-of-conduct to project docs: add Code of Conduct to project Aug 12, 2020
@brendankenny

Copy link
Copy Markdown
Contributor

something is going on with the yarn smoke oopif test. Fails locally as well. Currently looking into it.

@brendankenny brendankenny merged commit f08ab37 into GoogleChrome:master Aug 12, 2020
radum added a commit to radum/lighthouse that referenced this pull request Aug 13, 2020
* upstream/master: (42 commits)
  docs: add Code of Conduct to project (GoogleChrome#11212)
  docs(readme): add related project: lighthouse-viewer (GoogleChrome#11250)
  core(font-size): remove deprecated DOM.getFlattenedDocument (GoogleChrome#11248)
  misc: fix typo in method name (GoogleChrome#11239)
  i18n: make double dollar validation less strict (GoogleChrome#10299)
  misc: rephrase comments to be more inclusive (GoogleChrome#11228)
  misc: tweak gcp scripts to work in google corp (GoogleChrome#11233)
  v6.2.0 (GoogleChrome#11232)
  report: correctly display CLS in budget table (GoogleChrome#11209)
  report: vertically center thumbnails (GoogleChrome#11220)
  i18n: import (GoogleChrome#11225)
  tests: istanbul ignore inpage function (GoogleChrome#11229)
  deps(snyk): update script to prune <0.0.0 and update snapshot (GoogleChrome#11223)
  core(stacks): timeout stack detection (GoogleChrome#11172)
  core(config): unsized-images to default (GoogleChrome#11217)
  core(image-elements): collect CSS sizing, ShadowRoot, & position (GoogleChrome#11188)
  core: add FormElements gatherer (GoogleChrome#11062)
  new_audit: report animations not run on compositor (GoogleChrome#11105)
  tests: update chromestatus expecatations (GoogleChrome#11221)
  deps: update dot-prop secondary dependency (GoogleChrome#11198)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants