core: add FormElements gatherer#11062
Conversation
…ion to return input attributes
… a dependent function on page load
…formGatherer merging the forked repo
…a formless input we return the element path
patrickhulce
left a comment
There was a problem hiding this comment.
mostly the ts-ignore cleanup, but the impl still looks great!
| }); | ||
| } | ||
| if (child instanceof HTMLLabelElement) { | ||
| // @ts-ignore |
There was a problem hiding this comment.
this one shouldn't be needed either, what was going on?
There was a problem hiding this comment.
without it, it gives me a type error "Object is possibly 'undefined'."
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
…nto formGatherer merge from master .
…nput element on the form
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM 🎉
Woohoo congratulations on crossing the finish line here @gMakunde! :)
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
…nto formGatherer merge from master .
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
connorjclark
left a comment
There was a problem hiding this comment.
one last thing then LGTM!
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
cla bot is asking many many people from other PRs merged to master for consent. Ignoring it. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Summary
This PR will create a new gatherer that collects attributes that are important for creating an audit that will evaluate how well a developer uses autocomplete. More information is seen in the documentation linked and the related issue
feature
This is for a new form gatherer that collects form elements so we can perform audits that will evaluate how will it used autocomplete.
https://docs.google.com/document/d/1yiulNnV8uEy1jPaAEmWeHxHcQOzxpqvAV4hOFpXLJ1M/edit#
Related Issues/PRs
Issue #10450