Conversation
patrickhulce
left a comment
Collaborator
There was a problem hiding this comment.
❤️ this! had to do this with the CI viewer too obvs, huge feature :D
| 'use strict'; | ||
|
|
||
| /* global DOM, ViewerUIFeatures, ReportRenderer, DragAndDrop, GithubApi, PSIApi, logger, idbKeyval */ | ||
| /* global DOM, ViewerUIFeatures, ReportRenderer, DragAndDrop, GithubApi, PSIApi, logger, idbKeyval, __LIGHTHOUSE_JSON__ */ |
Collaborator
There was a problem hiding this comment.
we don't use it as a global, I think you just need to do some typescript fanagling
connorjclark
approved these changes
Jun 16, 2020
makunde
pushed a commit
to makunde/lighthouse
that referenced
this pull request
Jul 6, 2020
makunde
pushed a commit
to makunde/lighthouse
that referenced
this pull request
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever I'm hacking on the viewer i always want this feature.
I've also added a console.log in the viewer and the normal report. We've had users definitely appreciate learning about this global, so I think it's valuable.