report: update link for budgets audit#10944
Merged
Merged
Conversation
Contributor
Author
|
On second look I'm realizing that since this is exposed by default in the DevTools report UI (I think??) I think we need a dedicated guide for this topic. It's currently linking to Katie's doc, which assumes that someone is configuring the CLI to use budgets. |
Collaborator
What do you mean by exposed by default? You can't set a budget in DevTools at the moment.
so it's just gonna be this diagnostic with a link to budgets, a feature only supported in CLI atm. |
connorjclark
approved these changes
Jun 11, 2020
connorjclark
left a comment
Collaborator
There was a problem hiding this comment.
+1 but need to run yarn update:sample-json
paulirish
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the "Learn more" link in the budgets audit to avoid a redirect.