Skip to content

tests(smoke): use --debug in github action#10919

Merged
connorjclark merged 1 commit into
masterfrom
smokedebug
Jun 12, 2020
Merged

tests(smoke): use --debug in github action#10919
connorjclark merged 1 commit into
masterfrom
smokedebug

Conversation

@connorjclark

Copy link
Copy Markdown
Collaborator

Use --debug so log output is printed.

would have helped for #10906

@connorjclark connorjclark requested a review from a team as a code owner June 5, 2020 21:35
@connorjclark connorjclark requested review from Beytoven and removed request for a team June 5, 2020 21:35
@connorjclark connorjclark changed the title test(smoke): use --debug in github action tests(smoke): use --debug in github action Jun 5, 2020
@connorjclark

Copy link
Copy Markdown
Collaborator Author

not sure why it also prints out the HTML?

@connorjclark

Copy link
Copy Markdown
Collaborator Author

oh b/c MainDocumentContent is an expectation in dbw. hmmmm.

@brendankenny brendankenny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is --debug for a reason, it's very verbose (and does things like save the artifacts, etc) otherwise :)

What about adding something like "use --debug for more info" to the message printed on error to remind users that it exists (I had forgotten how to turn it on and had to go look that up when #10906 was erroring)...but I also don't feel super strongly if you really want this on the default CI run.

@connorjclark

Copy link
Copy Markdown
Collaborator Author

"use --debug for more info"

wouldn't help if the failure mode is only in CI.

yea i'd really like this in the default CI run

@connorjclark connorjclark merged commit 9796a0e into master Jun 12, 2020
@connorjclark connorjclark deleted the smokedebug branch June 12, 2020 23:22
@brendankenny

Copy link
Copy Markdown
Contributor

wouldn't help if the failure mode is only in CI.

Right, it would tell you to add --debug in that case. The tradeoff is having an extra commit to do that in the very rare case something like this happens vs 1000 extra lines of logging in the every-other-time case :)

makunde pushed a commit to makunde/lighthouse that referenced this pull request Jul 6, 2020
makunde pushed a commit to makunde/lighthouse that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants