clients(psi): show disclaimer and calclink#10936
Merged
Merged
Conversation
brendankenny
approved these changes
Jun 16, 2020
brendankenny
left a comment
Contributor
There was a problem hiding this comment.
for some reason I thought maybe we sent this text in the psi.js return value as well but I guess it's just the score gauge and scale.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6110 we removed this as there was already existing "may vary" text.
But then in cl/246846050 (may 2019) we updated the UI and got rid of PSI's text
So we should have restored this then, but didn't notice.