Skip to content

deps: update dot-prop secondary dependency#11198

Merged
Beytoven merged 1 commit into
GoogleChrome:masterfrom
wojtekmaj:fix/security-vulnerability
Aug 3, 2020
Merged

deps: update dot-prop secondary dependency#11198
Beytoven merged 1 commit into
GoogleChrome:masterfrom
wojtekmaj:fix/security-vulnerability

Conversation

@wojtekmaj

@wojtekmaj wojtekmaj commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

Summary

Fixes CVE-2020-8116 detected in secondary dependency dot-prop via two chains of dependencies:

  • update-notifier > configstore > dot-prop
  • configstore > dot-prop

Both updates to update-notifier and configstore drop support for Node 6 and/or 8, but are perfectly fine with Node 10 which is currently minimum supported Node version for Lighthouse.

Fixes [CVE-2020-8116](GHSA-ff7x-qrg7-qggm) detected in secondary dependency dot-prop via two chains of dependencies:
* update-notifier>configstore>dot-prop
* configstore>dot-prop

Bot updates to update-notifier and configstore drop support for Node 6 and/or 8, but are perfectly fine with Node 10 which is currently minimum supported Node version for Lighthouse.
@wojtekmaj wojtekmaj changed the title deps: Update dot-prop secondary dependency deps: update dot-prop secondary dependency Jul 31, 2020
@Beytoven Beytoven merged commit 40baa22 into GoogleChrome:master Aug 3, 2020
@wojtekmaj wojtekmaj deleted the fix/security-vulnerability branch August 10, 2020 06:57
radum added a commit to radum/lighthouse that referenced this pull request Aug 13, 2020
* upstream/master: (42 commits)
  docs: add Code of Conduct to project (GoogleChrome#11212)
  docs(readme): add related project: lighthouse-viewer (GoogleChrome#11250)
  core(font-size): remove deprecated DOM.getFlattenedDocument (GoogleChrome#11248)
  misc: fix typo in method name (GoogleChrome#11239)
  i18n: make double dollar validation less strict (GoogleChrome#10299)
  misc: rephrase comments to be more inclusive (GoogleChrome#11228)
  misc: tweak gcp scripts to work in google corp (GoogleChrome#11233)
  v6.2.0 (GoogleChrome#11232)
  report: correctly display CLS in budget table (GoogleChrome#11209)
  report: vertically center thumbnails (GoogleChrome#11220)
  i18n: import (GoogleChrome#11225)
  tests: istanbul ignore inpage function (GoogleChrome#11229)
  deps(snyk): update script to prune <0.0.0 and update snapshot (GoogleChrome#11223)
  core(stacks): timeout stack detection (GoogleChrome#11172)
  core(config): unsized-images to default (GoogleChrome#11217)
  core(image-elements): collect CSS sizing, ShadowRoot, & position (GoogleChrome#11188)
  core: add FormElements gatherer (GoogleChrome#11062)
  new_audit: report animations not run on compositor (GoogleChrome#11105)
  tests: update chromestatus expecatations (GoogleChrome#11221)
  deps: update dot-prop secondary dependency (GoogleChrome#11198)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants