Skip to content

new_audit(revert): move unsized-images to experimental due to perf impact#11317

Merged
patrickhulce merged 5 commits into
masterfrom
revert-unsized-images
Aug 26, 2020
Merged

new_audit(revert): move unsized-images to experimental due to perf impact#11317
patrickhulce merged 5 commits into
masterfrom
revert-unsized-images

Conversation

@lemcardenas

@lemcardenas lemcardenas commented Aug 25, 2020

Copy link
Copy Markdown
Contributor

Summary

Addresses #11289
While we figure out the OOM bug from unsized-images we should ensure its out of default

Related Issues/PRs

#11289 #11217 #11188

@lemcardenas lemcardenas requested a review from a team as a code owner August 25, 2020 21:09
@lemcardenas lemcardenas requested review from patrickhulce and removed request for a team August 25, 2020 21:09
@lemcardenas lemcardenas changed the title Reverted unsized-images audit due to OOM bug core(image-elements): reverted unsized-images changes due to OOM bug Aug 25, 2020

@patrickhulce patrickhulce left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this PR doesn't place unsized-images in experimental, should this PR be the place to do that?

yeah let's move it into experimental :)

@patrickhulce patrickhulce changed the title core(image-elements): reverted unsized-images changes due to OOM bug new_audit(revert): move unsized-images to experimental due to perf impact Aug 25, 2020
@paulirish

Copy link
Copy Markdown
Member

lg from my side!

after 6.3.0 is cut we can revert this PR and land it.
and then we have until 6.4.0 to fix the perf and the OOM.

@patrickhulce patrickhulce merged commit 27e4f68 into master Aug 26, 2020
@patrickhulce patrickhulce deleted the revert-unsized-images branch August 26, 2020 17:42
connorjclark added a commit that referenced this pull request Aug 27, 2020
connorjclark added a commit that referenced this pull request Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants