Skip to content

Custom ca certs - Setting Requests_ca_bundle environment variable#2813

Merged
derekbekoe merged 3 commits intoAzure:api-profile-supportfrom
derekbekoe:custom-ca-certs
Apr 10, 2017
Merged

Custom ca certs - Setting Requests_ca_bundle environment variable#2813
derekbekoe merged 3 commits intoAzure:api-profile-supportfrom
derekbekoe:custom-ca-certs

Conversation

@derekbekoe
Copy link
Copy Markdown
Member

@derekbekoe derekbekoe commented Apr 10, 2017

Closes #2267

@yugangw-msft
Copy link
Copy Markdown
Contributor

We were hitting SSL errors as the ARM endpoint certificate is not trusted,

@derekbekoe, I assume this is for azure stack work, right?
Also the change here doesn't seem to apply on data plane clients, but since only ARM endpoint is involved, guess it is ok.

@derekbekoe
Copy link
Copy Markdown
Member Author

@yugangw-msft yes it was for stack

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 10, 2017

Codecov Report

Merging #2813 into api-profile-support will decrease coverage by 0.01%.
The diff coverage is 46.15%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           api-profile-support    #2813      +/-   ##
=======================================================
- Coverage                63.02%   63.01%   -0.02%     
=======================================================
  Files                      483      483              
  Lines                    26212    26220       +8     
  Branches                  3973     3975       +2     
=======================================================
+ Hits                     16520    16522       +2     
- Misses                    8653     8658       +5     
- Partials                  1039     1040       +1
Impacted Files Coverage Δ
...cli-core/azure/cli/core/commands/client_factory.py 89.74% <100%> (ø) ⬆️
...li-core/azure/cli/core/test_utils/vcr_test_base.py 70.58% <100%> (ø) ⬆️
src/azure-cli-core/azure/cli/core/_debug.py 66.66% <33.33%> (-20.84%) ⬇️
src/azure-cli-core/azure/cli/core/_profile.py 84.23% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852e535...4b3134c. Read the comment docs.

@derekbekoe derekbekoe merged this pull request into Azure:api-profile-support Apr 10, 2017
@derekbekoe derekbekoe deleted the custom-ca-certs branch April 10, 2017 21:53
derekbekoe added a commit that referenced this pull request Apr 11, 2017
- Use published SDKs available on PyPI now
- Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812)
- Custom ca certs - Setting Requests_ca_bundle environment variable (#2813)
- changes for 2015-* profile to work against azure stack  (#2794)
- Loading versioned Resources client and versioned models in VM
- Updating the supported api-versions for the 2015-example profile
- Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit)
- Support multi-API versioned Storage dataplane SDK (#2796)
- Support multi-versioned mgmt SDK (#2526)
- Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410)
- Add profile switching params and profile listing command (#2398)
- Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
@derekbekoe derekbekoe mentioned this pull request Apr 11, 2017
3 tasks
derekbekoe added a commit that referenced this pull request Apr 13, 2017
- Use published SDKs available on PyPI now
- Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812)
- Custom ca certs - Setting Requests_ca_bundle environment variable (#2813)
- changes for 2015-* profile to work against azure stack  (#2794)
- Loading versioned Resources client and versioned models in VM
- Updating the supported api-versions for the 2015-example profile
- Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit)
- Support multi-API versioned Storage dataplane SDK (#2796)
- Support multi-versioned mgmt SDK (#2526)
- Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410)
- Add profile switching params and profile listing command (#2398)
- Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
derekbekoe added a commit that referenced this pull request Apr 14, 2017
* API Profile Support

- Use published SDKs available on PyPI now
- Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812)
- Custom ca certs - Setting Requests_ca_bundle environment variable (#2813)
- changes for 2015-* profile to work against azure stack  (#2794)
- Loading versioned Resources client and versioned models in VM
- Updating the supported api-versions for the 2015-example profile
- Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit)
- Support multi-API versioned Storage dataplane SDK (#2796)
- Support multi-versioned mgmt SDK (#2526)
- Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410)
- Add profile switching params and profile listing command (#2398)
- Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set

* Address code review feedback

Fix pylint and pep8 (+7 squashed commits)
Squashed commits:
[f1d4d52] Refactor to use joint method
[f43785a] Use generic method to get versioned SDK attributes
[2100dd2] Add log debug if enum default not found
[5767f41] Add single_placement_group back in for vmss
[05ca8bc] Revert a test change. It has been fixed in master.
[cdf4211] Simplify str override method
[281c755] Clarify use of getattr

* Fix patching the operation versions

* Fix wrong import

* Rename shared to _shared

* Add message to cloud debug message

* Remove public method ‘get_versioned_sdk_path’ from azure.cli.core.profiles

* Remove unused import

* Use setattr

* Add API version comparisons

* Add method docs

* Fix failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants