Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId"#2410
Merged
derekbekoe merged 2 commits intoAzure:api-profile-supportfrom Mar 10, 2017
Conversation
…DirectoryResourceId"
Codecov Report
@@ Coverage Diff @@
## api-profile-support #2410 +/- ##
====================================================
Coverage 72.34% 72.34%
====================================================
Files 325 325
Lines 18311 18311
Branches 2707 2707
====================================================
Hits 13248 13248
+ Misses 4230 4228 -2
- Partials 833 835 +2
Continue to review full report at Codecov.
|
Contributor
|
Let us chat. We used this end point for the reason that the token could be picked up by xplat-cli for ASM command, so if possible I would like see workaround from stack side |
Member
Author
|
@yugangw-msft look good to you? |
Contributor
|
@derekbekoe , sorry for the delay, I just forgot to approve it., |
yugangw-msft
approved these changes
Mar 10, 2017
derekbekoe
added a commit
that referenced
this pull request
Mar 16, 2017
…DirectoryResourceId" (#2410) * Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" * Modify one more occurrence
derekbekoe
added a commit
that referenced
this pull request
Mar 17, 2017
…DirectoryResourceId" (#2410) * Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" * Modify one more occurrence
derekbekoe
added a commit
that referenced
this pull request
Mar 21, 2017
…DirectoryResourceId" (#2410) * Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" * Modify one more occurrence
derekbekoe
added a commit
to derekbekoe/azure-cli
that referenced
this pull request
Mar 27, 2017
…DirectoryResourceId" (Azure#2410) * Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" * Modify one more occurrence
derekbekoe
added a commit
that referenced
this pull request
Apr 4, 2017
…DirectoryResourceId" (#2410) * Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" * Modify one more occurrence
derekbekoe
added a commit
that referenced
this pull request
Apr 7, 2017
…DirectoryResourceId" (#2410) * Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" * Modify one more occurrence
derekbekoe
added a commit
that referenced
this pull request
Apr 7, 2017
…DirectoryResourceId" (#2410) * Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" * Modify one more occurrence
derekbekoe
added a commit
that referenced
this pull request
Apr 10, 2017
…DirectoryResourceId" (#2410) * Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" * Modify one more occurrence
derekbekoe
added a commit
that referenced
this pull request
Apr 11, 2017
- Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
derekbekoe
added a commit
that referenced
this pull request
Apr 13, 2017
- Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
derekbekoe
added a commit
that referenced
this pull request
Apr 14, 2017
* API Profile Support - Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Address code review feedback Fix pylint and pep8 (+7 squashed commits) Squashed commits: [f1d4d52] Refactor to use joint method [f43785a] Use generic method to get versioned SDK attributes [2100dd2] Add log debug if enum default not found [5767f41] Add single_placement_group back in for vmss [05ca8bc] Revert a test change. It has been fixed in master. [cdf4211] Simplify str override method [281c755] Clarify use of getattr * Fix patching the operation versions * Fix wrong import * Rename shared to _shared * Add message to cloud debug message * Remove public method ‘get_versioned_sdk_path’ from azure.cli.core.profiles * Remove unused import * Use setattr * Add API version comparisons * Add method docs * Fix failing test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2266