changes for 2015-* profile to work against azure stack by bganapa · Pull Request #2794 · Azure/azure-cli

bganapa · 2017-04-07T01:15:14Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

Each command and parameter has a meaningful description.
Each new command has a test.

msftclas · 2017-04-07T01:15:18Z

@bganapa,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

bganapa · 2017-04-07T01:18:46Z

cc:@derekbekoe

derekbekoe

The changes look promising but added some comments.

derekbekoe · 2017-04-07T07:16:24Z

src/command_modules/azure-cli-storage/azure/cli/command_modules/storage/commands.py

This doesn't look correct.
This is a dataplane command for storage and the API version is wrong.

derekbekoe · 2017-04-07T17:51:54Z

src/command_modules/azure-cli-storage/setup.py

This won't be needed after #2796.

reverted this commit

derekbekoe · 2017-04-07T17:53:29Z

src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/commands.py

Currently, we support 2015-06-15 and 2016-04-30-preview.
So there's nothing else to add to this list right now.

removed the todo

derekbekoe · 2017-04-07T17:54:06Z

src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/custom.py

style: pylint will likely complain. There should be a space after the ,

derekbekoe · 2017-04-07T17:54:21Z

src/command_modules/azure-cli-vm/setup.py

Can remove this due to #2796

derekbekoe · 2017-04-07T17:56:04Z

src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_template_builder.py

Should get the API version from get_api_version like you do for vm_api_version above.

Same with av_set_api_version below.

fixed them.. thanks for the review Derek!

Squashed commit: [89a4df6] loading versioned object models for vm [0ec5d8a] loading 0.30.0 version of the package azure-storage [4ac06ba] resolving a bad merge, replacing _util with util [a361e61] vm template builder changes for 2015-* profile [6e84045] Loading versioned Resources client and versioned models in VM [cf28976] Updating the supported api-versions for the 2015-example profile [b58cad7] Fixing network , compute sdk load errors for 2015-* profiles (+5 squashed commit) Squashed commit: [4ac06ba] resolving a bad merge, replacing _util with util [a361e61] vm template builder changes for 2015-* profile [6e84045] Loading versioned Resources client and versioned models in VM [cf28976] Updating the supported api-versions for the 2015-example profile [b58cad7] Fixing network , compute sdk load errors for 2015-* profiles (+3 squashed commit) Squashed commit: [6e84045] Loading versioned Resources client and versioned models in VM [cf28976] Updating the supported api-versions for the 2015-example profile [b58cad7] Fixing network , compute sdk load errors for 2015-* profiles (+1 squashed commits) Squashed commits: [b58cad7] Fixing network , compute sdk load errors for 2015-* profiles

codecov-io · 2017-04-08T00:10:29Z

Codecov Report

Merging #2794 into api-profile-support will decrease coverage by <.01%.
The diff coverage is 85%.

@@                   Coverage Diff                   @@
##           api-profile-support    #2794      +/-   ##
=======================================================
- Coverage                63.03%   63.02%   -0.01%     
=======================================================
  Files                      483      483              
  Lines                    26184    26203      +19     
  Branches                  3963     3971       +8     
=======================================================
+ Hits                     16504    16515      +11     
+ Misses                    8653     8649       -4     
- Partials                  1027     1039      +12

Impacted Files	Coverage Δ
...c/azure-cli-core/azure/cli/core/profiles/shared.py	`80.76% <ø> (ø)`	⬆️
...ure/cli/command_modules/network/_client_factory.py	`93.65% <0%> (-1.52%)`	⬇️
...e-cli-vm/azure/cli/command_modules/vm/_vm_utils.py	`76.92% <100%> (+0.92%)`	⬆️
...re-cli-acs/azure/cli/command_modules/acs/custom.py	`35.3% <100%> (ø)`	⬆️
.../azure/cli/command_modules/vm/_template_builder.py	`77.24% <100%> (+0.61%)`	⬆️
...etwork/azure/cli/command_modules/network/custom.py	`62.46% <100%> (+0.03%)`	⬆️
src/azure-cli-core/azure/cli/core/commands/arm.py	`89.23% <100%> (+0.02%)`	⬆️
...ure-cli-core/azure/cli/core/commands/validators.py	`97.72% <100%> (+0.05%)`	⬆️
...re-cli-dls/azure/cli/command_modules/dls/custom.py	`80.57% <50%> (+0.14%)`	⬆️
...ource/azure/cli/command_modules/resource/custom.py	`51.12% <50%> (-0.11%)`	⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1064b...401b857. Read the comment docs.

* addressing cr comments and fixing pylint errors (+7 squashed commit) Squashed commit: [89a4df6] loading versioned object models for vm [0ec5d8a] loading 0.30.0 version of the package azure-storage [4ac06ba] resolving a bad merge, replacing _util with util [a361e61] vm template builder changes for 2015-* profile [6e84045] Loading versioned Resources client and versioned models in VM [cf28976] Updating the supported api-versions for the 2015-example profile [b58cad7] Fixing network , compute sdk load errors for 2015-* profiles (+5 squashed commit) Squashed commit: [4ac06ba] resolving a bad merge, replacing _util with util [a361e61] vm template builder changes for 2015-* profile [6e84045] Loading versioned Resources client and versioned models in VM [cf28976] Updating the supported api-versions for the 2015-example profile [b58cad7] Fixing network , compute sdk load errors for 2015-* profiles (+3 squashed commit) Squashed commit: [6e84045] Loading versioned Resources client and versioned models in VM [cf28976] Updating the supported api-versions for the 2015-example profile [b58cad7] Fixing network , compute sdk load errors for 2015-* profiles (+1 squashed commits) Squashed commits: [b58cad7] Fixing network , compute sdk load errors for 2015-* profiles * resolving a badmerge and fixing storage dataplane reference

- Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set

* API Profile Support - Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Address code review feedback Fix pylint and pep8 (+7 squashed commits) Squashed commits: [f1d4d52] Refactor to use joint method [f43785a] Use generic method to get versioned SDK attributes [2100dd2] Add log debug if enum default not found [5767f41] Add single_placement_group back in for vmss [05ca8bc] Revert a test change. It has been fixed in master. [cdf4211] Simplify str override method [281c755] Clarify use of getattr * Fix patching the operation versions * Fix wrong import * Rename shared to _shared * Add message to cloud debug message * Remove public method ‘get_versioned_sdk_path’ from azure.cli.core.profiles * Remove unused import * Use setattr * Add API version comparisons * Add method docs * Fix failing test

…2794)

msftclas added the cla-not-required label Apr 7, 2017

derekbekoe suggested changes Apr 7, 2017

View reviewed changes

derekbekoe force-pushed the api-profile-support branch from 4fb721f to cd1064b Compare April 7, 2017 22:38

bganapa force-pushed the vm-storage-changes branch from 89a4df6 to 79dc4a2 Compare April 7, 2017 23:33

bganapa force-pushed the vm-storage-changes branch from 79dc4a2 to 6cca271 Compare April 7, 2017 23:38

resolving a badmerge and fixing storage dataplane reference

401b857

derekbekoe approved these changes Apr 7, 2017

View reviewed changes

derekbekoe merged commit 188cdd2 into Azure:api-profile-support Apr 8, 2017

derekbekoe mentioned this pull request Apr 11, 2017

API Profile Support #2834

Merged

3 tasks

haroldrandom added the cla-not-required label Oct 25, 2019

00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021

[AKS] support custom private dns zone for aks private cluster (Azure#…

5cc57d5

…2794)

Conversation

bganapa commented Apr 7, 2017

General Guidelines

Command Guidelines

Uh oh!

msftclas commented Apr 7, 2017

Uh oh!

bganapa commented Apr 7, 2017

Uh oh!

derekbekoe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-io commented Apr 8, 2017 •

edited

Loading