Support multi-API versioned Storage dataplane SDK#2796
Merged
derekbekoe merged 2 commits intoAzure:api-profile-supportfrom Apr 7, 2017
Merged
Support multi-API versioned Storage dataplane SDK#2796derekbekoe merged 2 commits intoAzure:api-profile-supportfrom
derekbekoe merged 2 commits intoAzure:api-profile-supportfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## api-profile-support #2796 +/- ##
=======================================================
+ Coverage 62.99% 63.03% +0.03%
=======================================================
Files 483 483
Lines 26140 26176 +36
Branches 3959 3961 +2
=======================================================
+ Hits 16467 16499 +32
Misses 8647 8647
- Partials 1026 1030 +4
Continue to review full report at Codecov.
|
3 tasks
lmazuel
approved these changes
Apr 7, 2017
Member
lmazuel
left a comment
There was a problem hiding this comment.
@derekbekoe LGTM
General comment, maybe you should anticipate the profile support and called it azure.cli.storagesdk.v2016_05_31 instead of azure.cli.storagesdk (I guess you will eventually need it)
Member
|
@derekbekoe ok I think I get it, it's your general name in: DATA_STORAGE = (None, 'azure.cli.storagesdk', None)bu you are doing it in your package. |
Member
|
@derekbekoe (sorry I should think more before writing :p) Actually, since I guess we should package this Storage package under a more generic name, so SDK users can decide to use it as well. Like |
Member
Author
|
Changed to use |
derekbekoe
added a commit
that referenced
this pull request
Apr 7, 2017
* Support multi-API versioned Storage dataplane SDK * Rename multi-api module
derekbekoe
added a commit
that referenced
this pull request
Apr 10, 2017
* Support multi-API versioned Storage dataplane SDK * Rename multi-api module
derekbekoe
added a commit
that referenced
this pull request
Apr 11, 2017
- Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
derekbekoe
added a commit
that referenced
this pull request
Apr 13, 2017
- Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
derekbekoe
added a commit
that referenced
this pull request
Apr 14, 2017
* API Profile Support - Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Address code review feedback Fix pylint and pep8 (+7 squashed commits) Squashed commits: [f1d4d52] Refactor to use joint method [f43785a] Use generic method to get versioned SDK attributes [2100dd2] Add log debug if enum default not found [5767f41] Add single_placement_group back in for vmss [05ca8bc] Revert a test change. It has been fixed in master. [cdf4211] Simplify str override method [281c755] Clarify use of getattr * Fix patching the operation versions * Fix wrong import * Rename shared to _shared * Add message to cloud debug message * Remove public method ‘get_versioned_sdk_path’ from azure.cli.core.profiles * Remove unused import * Use setattr * Add API version comparisons * Add method docs * Fix failing test
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.