Add profile switching params and profile listing command#2398
Merged
derekbekoe merged 6 commits intoAzure:api-profile-supportfrom Mar 7, 2017
Merged
Add profile switching params and profile listing command#2398derekbekoe merged 6 commits intoAzure:api-profile-supportfrom
derekbekoe merged 6 commits intoAzure:api-profile-supportfrom
Conversation
- Modify ‘az cloud register’ and ‘az cloud update’ to include the ‘—profile’ parameter - Add ability to view all supported API versions without querying a cloud note: With this change, switching profile will not change anything as they are just example profiles.
Codecov Report
@@ Coverage Diff @@
## api-profile-support #2398 +/- ##
=======================================================
+ Coverage 72.33% 72.34% +0.01%
=======================================================
Files 323 325 +2
Lines 18273 18311 +38
Branches 2701 2707 +6
=======================================================
+ Hits 13217 13248 +31
- Misses 4223 4230 +7
Partials 833 833
Continue to review full report at Codecov.
|
yugangw-msft
reviewed
Mar 7, 2017
Contributor
yugangw-msft
left a comment
There was a problem hiding this comment.
Left 2 questions for clarifications. The rest LGTM
| c = Cloud(cloud_name) | ||
| for arg in cloud_args: | ||
| if arg == 'profile' and cloud_args[arg] is not None: | ||
| c.profile = cloud_args[arg] |
Contributor
There was a problem hiding this comment.
Saw this pattern been used a few times. Can this if branch be moved out of the loop and become
c.profile = cloud_args.get('profile', None)
Member
Author
There was a problem hiding this comment.
Yeah that works. Will change.
| except configparser.DuplicateSectionError: | ||
| if not overwrite: | ||
| raise CloudAlreadyRegisteredException(cloud.name) | ||
| if cloud.profile is not None: |
Contributor
There was a problem hiding this comment.
do we need to differentiate between None and empty string? If yes, what does empty string imply?
Member
Author
There was a problem hiding this comment.
This is no longer needed. if cloud.profile is sufficient.
derekbekoe
added a commit
that referenced
this pull request
Mar 16, 2017
* Add profile switching and profile listing - Modify ‘az cloud register’ and ‘az cloud update’ to include the ‘—profile’ parameter - Add ability to view all supported API versions without querying a cloud note: With this change, switching profile will not change anything as they are just example profiles. * Fix pylint!! * Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Fix pep8 * Fix hasattr() behaving differently in Python 3 * Code review changes
derekbekoe
added a commit
that referenced
this pull request
Mar 17, 2017
* Add profile switching and profile listing - Modify ‘az cloud register’ and ‘az cloud update’ to include the ‘—profile’ parameter - Add ability to view all supported API versions without querying a cloud note: With this change, switching profile will not change anything as they are just example profiles. * Fix pylint!! * Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Fix pep8 * Fix hasattr() behaving differently in Python 3 * Code review changes
derekbekoe
added a commit
that referenced
this pull request
Mar 21, 2017
* Add profile switching and profile listing - Modify ‘az cloud register’ and ‘az cloud update’ to include the ‘—profile’ parameter - Add ability to view all supported API versions without querying a cloud note: With this change, switching profile will not change anything as they are just example profiles. * Fix pylint!! * Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Fix pep8 * Fix hasattr() behaving differently in Python 3 * Code review changes
derekbekoe
added a commit
to derekbekoe/azure-cli
that referenced
this pull request
Mar 27, 2017
* Add profile switching and profile listing - Modify ‘az cloud register’ and ‘az cloud update’ to include the ‘—profile’ parameter - Add ability to view all supported API versions without querying a cloud note: With this change, switching profile will not change anything as they are just example profiles. * Fix pylint!! * Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Fix pep8 * Fix hasattr() behaving differently in Python 3 * Code review changes
derekbekoe
added a commit
that referenced
this pull request
Apr 4, 2017
* Add profile switching and profile listing - Modify ‘az cloud register’ and ‘az cloud update’ to include the ‘—profile’ parameter - Add ability to view all supported API versions without querying a cloud note: With this change, switching profile will not change anything as they are just example profiles. * Fix pylint!! * Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Fix pep8 * Fix hasattr() behaving differently in Python 3 * Code review changes
derekbekoe
added a commit
that referenced
this pull request
Apr 7, 2017
* Add profile switching and profile listing - Modify ‘az cloud register’ and ‘az cloud update’ to include the ‘—profile’ parameter - Add ability to view all supported API versions without querying a cloud note: With this change, switching profile will not change anything as they are just example profiles. * Fix pylint!! * Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Fix pep8 * Fix hasattr() behaving differently in Python 3 * Code review changes
derekbekoe
added a commit
that referenced
this pull request
Apr 7, 2017
* Add profile switching and profile listing - Modify ‘az cloud register’ and ‘az cloud update’ to include the ‘—profile’ parameter - Add ability to view all supported API versions without querying a cloud note: With this change, switching profile will not change anything as they are just example profiles. * Fix pylint!! * Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Fix pep8 * Fix hasattr() behaving differently in Python 3 * Code review changes
derekbekoe
added a commit
that referenced
this pull request
Apr 10, 2017
* Add profile switching and profile listing - Modify ‘az cloud register’ and ‘az cloud update’ to include the ‘—profile’ parameter - Add ability to view all supported API versions without querying a cloud note: With this change, switching profile will not change anything as they are just example profiles. * Fix pylint!! * Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Fix pep8 * Fix hasattr() behaving differently in Python 3 * Code review changes
derekbekoe
added a commit
that referenced
this pull request
Apr 11, 2017
- Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
derekbekoe
added a commit
that referenced
this pull request
Apr 13, 2017
- Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
derekbekoe
added a commit
that referenced
this pull request
Apr 14, 2017
* API Profile Support - Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Address code review feedback Fix pylint and pep8 (+7 squashed commits) Squashed commits: [f1d4d52] Refactor to use joint method [f43785a] Use generic method to get versioned SDK attributes [2100dd2] Add log debug if enum default not found [5767f41] Add single_placement_group back in for vmss [05ca8bc] Revert a test change. It has been fixed in master. [cdf4211] Simplify str override method [281c755] Clarify use of getattr * Fix patching the operation versions * Fix wrong import * Rename shared to _shared * Add message to cloud debug message * Remove public method ‘get_versioned_sdk_path’ from azure.cli.core.profiles * Remove unused import * Use setattr * Add API version comparisons * Add method docs * Fix failing test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: With this change, switching profile will not change anything as they are just example profiles.
FYI @lmazuel For the
_shared.pyfile change. This would contain the resource type to api version map.Closes #2280
Closes #2279
Closes #2265