Loading versioned models for network and resources (2015 profile support)#2812
Merged
derekbekoe merged 1 commit intoAzure:api-profile-supportfrom Apr 10, 2017
Merged
Conversation
188cdd2 to
ce907aa
Compare
fd3340f to
3dfbb5f
Compare
…ialization changes for 2015-* profile
3dfbb5f to
d4ea302
Compare
Codecov Report
@@ Coverage Diff @@
## api-profile-support #2812 +/- ##
=======================================================
- Coverage 63.02% 63.02% -0.01%
=======================================================
Files 483 483
Lines 26212 26225 +13
Branches 3973 3978 +5
=======================================================
+ Hits 16520 16528 +8
- Misses 8653 8657 +4
- Partials 1039 1040 +1
Continue to review full report at Codecov.
|
tjprescott
reviewed
Apr 10, 2017
| 'private_ip_address': private_ip_address, | ||
| 'subnet': Subnet(id=subnet) | ||
| } | ||
| if get_api_version(ResourceType.MGMT_NETWORK) in ['2016-09-01']: |
Member
There was a problem hiding this comment.
Does this mean we're going to have to manually add '2016-12-01' to everywhere this list occurs to support the next API version? This would imply that this block applies only to this API version--nothing prior or later.
Member
|
Why was this merged with no reviewer approval? |
Member
Author
|
@tjprescott Yeah I'm taking a look at this, #2579, #2578 and #2577 before my PR to master branch. |
derekbekoe
added a commit
that referenced
this pull request
Apr 11, 2017
- Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
derekbekoe
added a commit
that referenced
this pull request
Apr 13, 2017
- Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set
derekbekoe
added a commit
that referenced
this pull request
Apr 14, 2017
* API Profile Support - Use published SDKs available on PyPI now - Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812) - Custom ca certs - Setting Requests_ca_bundle environment variable (#2813) - changes for 2015-* profile to work against azure stack (#2794) - Loading versioned Resources client and versioned models in VM - Updating the supported api-versions for the 2015-example profile - Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit) - Support multi-API versioned Storage dataplane SDK (#2796) - Support multi-versioned mgmt SDK (#2526) - Fix token "management" endpoint is being used in the place of "activeDirectoryResourceId" (#2410) - Add profile switching params and profile listing command (#2398) - Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set * Address code review feedback Fix pylint and pep8 (+7 squashed commits) Squashed commits: [f1d4d52] Refactor to use joint method [f43785a] Use generic method to get versioned SDK attributes [2100dd2] Add log debug if enum default not found [5767f41] Add single_placement_group back in for vmss [05ca8bc] Revert a test change. It has been fixed in master. [cdf4211] Simplify str override method [281c755] Clarify use of getattr * Fix patching the operation versions * Fix wrong import * Rename shared to _shared * Add message to cloud debug message * Remove public method ‘get_versioned_sdk_path’ from azure.cli.core.profiles * Remove unused import * Use setattr * Add API version comparisons * Add method docs * Fix failing test
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* chore: clean up recordings * add recording processor * replace with mocks * revert arg change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.