Use platform.js for Google+ sharing functionality#8129
Merged
jeherve merged 1 commit intoAutomattic:masterfrom Nov 21, 2017
Merged
Use platform.js for Google+ sharing functionality#8129jeherve merged 1 commit intoAutomattic:masterfrom
jeherve merged 1 commit intoAutomattic:masterfrom
Conversation
Member
|
Also reported in 780657-zen |
Contributor
|
Just popping in to say that the folks in this thread say that the patch works: https://wordpress.org/support/topic/5-5-official-google-button-not-showing/ |
Contributor
|
Reverts #7912 |
zinigor
approved these changes
Nov 20, 2017
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
jeherve
approved these changes
Nov 21, 2017
Member
jeherve
left a comment
There was a problem hiding this comment.
Seems to work on my end. Merging!
jeherve
pushed a commit
that referenced
this pull request
Nov 21, 2017
Member
|
Cherry-picked to |
jeherve
pushed a commit
that referenced
this pull request
Nov 22, 2017
jeherve
pushed a commit
that referenced
this pull request
Nov 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
plusone.min.js and platform.min.js are currently broken, gapi.plusone is undefined. The documentation at https://developers.google.com/+/web/+1button/ uses platform.js, which is working fine.