Skip to content

Publicize: update message length to match Twitter's new limit.#8219

Merged
jeherve merged 1 commit intomasterfrom
update/publicize-length-limit
Nov 22, 2017
Merged

Publicize: update message length to match Twitter's new limit.#8219
jeherve merged 1 commit intomasterfrom
update/publicize-length-limit

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Nov 20, 2017

Fixes #8134

Things to test

  1. Starting in Posts > Add New.
  2. If you use Publicize on your site, you will see the following box:

screenshot 2017-11-09 at 13 37 59

Since Twitter now supports more characters, we need to expand the limit accordingly (280 characters minus 23 characters for the link, and a space):
https://blog.twitter.com/official/en_us/topics/product/2017/tweetingmadeeasier.html

Proposed changelog entry for your changes:

  • Publicize: update message length to match Twitter's new 280 character limit.

@jeherve jeherve added [Feature] Publicize Now Jetpack Social, auto-sharing [Pri] High [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Nov 20, 2017
@jeherve jeherve self-assigned this Nov 20, 2017
@jeherve jeherve requested a review from a team as a code owner November 20, 2017 21:42
zinigor
zinigor approved these changes Nov 20, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 20, 2017
@zinigor zinigor added this to the 5.5.1 milestone Nov 20, 2017
@jeherve jeherve merged commit 0466bbf into master Nov 22, 2017
@jeherve jeherve deleted the update/publicize-length-limit branch November 22, 2017 11:42
@jeherve jeherve removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 22, 2017
jeherve added a commit that referenced this pull request Nov 22, 2017
@jeherve
Publicize: update message length to match Twitter's new limit. (#8219)
da241fc 
Fixes #8134
@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Nov 22, 2017

Cherry-picked to branch-5.5 in 0466bbf

jeherve added a commit that referenced this pull request Nov 22, 2017
@jeherve
Changelog: add #8219
11e6786
jeherve pushed a commit that referenced this pull request Nov 22, 2017
@zinigor @jeherve
Running changelog for 5.5.1 (#8217)
1edd96b 
* Added changelog for #8201 and #8177.

* Changelog 5.5.1: create base for changelog.

* Fix typo and update release post link.

* Changelog: add #8167

* Changelog: add #8204

* Changelog: add #8129

* Changelog: add #8225

* Changelog: add #8219
jeherve pushed a commit that referenced this pull request Nov 22, 2017
@zinigor @jeherve
Running changelog for 5.5.1 (#8217)
cadafb3 
* Added changelog for #8201 and #8177.

* Changelog 5.5.1: create base for changelog.

* Fix typo and update release post link.

* Changelog: add #8167

* Changelog: add #8204

* Changelog: add #8129

* Changelog: add #8225

* Changelog: add #8219
@jeherve jeherve mentioned this pull request Dec 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zinigor zinigor zinigor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Publicize Now Jetpack Social, auto-sharing [Pri] High

Projects

None yet

Milestone

5.5.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jeherve @zinigor