Skip to content

Sync: Don't sync user if the user is null.#8204

Merged
oskosk merged 1 commit intomasterfrom
fix/user-sync
Nov 20, 2017
Merged

Sync: Don't sync user if the user is null.#8204
oskosk merged 1 commit intomasterfrom
fix/user-sync

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Nov 17, 2017

Lets not send the user on logout if the user is empty.

Fixes #8175

Changes proposed in this Pull Request:

  • For some reason some sites try to send us an empy value when the user logs out. It could be that the user is already logged out.

This prevents the event from being sent.

Testing instructions:

  • Do the tests pass?

@enejb
Sync: Don't sync user if the user is null.
9ed3955 
lets not send the user on logout if the user is empty.
@enejb enejb added [Package] Sync [Status] Needs Review This PR is ready for review. labels Nov 17, 2017
@enejb enejb self-assigned this Nov 17, 2017
@enejb enejb requested review from gititon and lezama November 17, 2017 21:21
@enejb enejb requested a review from a team as a code owner November 17, 2017 21:21
@enejb enejb mentioned this pull request Nov 17, 2017
Closed
@oskosk oskosk merged commit 026b7e5 into master Nov 20, 2017
@oskosk oskosk deleted the fix/user-sync branch November 20, 2017 15:17
@oskosk oskosk removed the [Status] Needs Review This PR is ready for review. label Nov 20, 2017
@jeherve jeherve added the Bug When a feature is broken and / or not performing as intended label Nov 20, 2017
jeherve pushed a commit that referenced this pull request Nov 20, 2017
@enejb @jeherve
Sync: Don't sync user if the user is null. (#8204)
45599ab 
lets not send the user on logout if the user is empty.
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Nov 20, 2017

Cherry-picked to branch-5.5 in 45599ab

@jeherve jeherve added this to the 5.5.1 milestone Nov 20, 2017
jeherve added a commit that referenced this pull request Nov 20, 2017
@jeherve
Changelog: add #8204
b2b49c6
jeherve pushed a commit that referenced this pull request Nov 22, 2017
@zinigor @jeherve
Running changelog for 5.5.1 (#8217)
1edd96b 
* Added changelog for #8201 and #8177.

* Changelog 5.5.1: create base for changelog.

* Fix typo and update release post link.

* Changelog: add #8167

* Changelog: add #8204

* Changelog: add #8129

* Changelog: add #8225

* Changelog: add #8219
jeherve pushed a commit that referenced this pull request Nov 22, 2017
@zinigor @jeherve
Running changelog for 5.5.1 (#8217)
cadafb3 
* Added changelog for #8201 and #8177.

* Changelog 5.5.1: create base for changelog.

* Fix typo and update release post link.

* Changelog: add #8167

* Changelog: add #8204

* Changelog: add #8129

* Changelog: add #8225

* Changelog: add #8219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezama lezama lezama approved these changes

@gititon gititon Awaiting requested review from gititon

+1 more reviewer

@oskosk oskosk oskosk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@enejb enejb

Labels

Bug When a feature is broken and / or not performing as intended [Package] Sync

Projects

None yet

Milestone

5.5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@enejb @jeherve @lezama @oskosk