Skip to content

Sync: add broken test#8167

Merged
enejb merged 2 commits intomasterfrom
fix/fatal-error-plugin-actions
Nov 16, 2017
Merged

Sync: add broken test#8167
enejb merged 2 commits intomasterfrom
fix/fatal-error-plugin-actions

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Nov 14, 2017

Does not fix #8164
But hopes to.

Changes proposed in this Pull Request:

  • Confirm the fatal with a test.

Testing instructions:

  • Does it pass the tests?

Proposed changelog entry for your changes:

@enejb enejb requested a review from a team as a code owner November 14, 2017 21:28
@enejb enejb requested a review from lezama November 14, 2017 21:29
@enejb enejb self-assigned this Nov 14, 2017
@jeherve jeherve added [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended [Pri] BLOCKER labels Nov 15, 2017
@jeherve jeherve changed the title Add broken test Sync: add broken test Nov 15, 2017
Copy link
Copy Markdown
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what I was talking about :)

@enejb enejb merged commit b0f1aa8 into master Nov 16, 2017
@enejb enejb deleted the fix/fatal-error-plugin-actions branch November 16, 2017 16:30
@matticbot matticbot removed the [Status] Needs Review This PR is ready for review. label Nov 16, 2017
@richardmtl
Copy link
Copy Markdown
Contributor

Noting that the reporter says the Jetpack beta works (which I presume includes this patch). https://wordpress.org/support/topic/jetpack-causing-error-in-admin-page/#post-9695788

@jeherve jeherve added this to the 5.5.1 milestone Nov 20, 2017
jeherve pushed a commit that referenced this pull request Nov 20, 2017
* Add broken test

* Add empty array
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Nov 20, 2017

Cherry picked to branch-5.5 in 9f0b030

jeherve added a commit that referenced this pull request Nov 20, 2017
jeherve pushed a commit that referenced this pull request Nov 22, 2017
* Added changelog for #8201 and #8177.

* Changelog 5.5.1: create base for changelog.

* Fix typo and update release post link.

* Changelog: add #8167

* Changelog: add #8204

* Changelog: add #8129

* Changelog: add #8225

* Changelog: add #8219
jeherve pushed a commit that referenced this pull request Nov 22, 2017
* Added changelog for #8201 and #8177.

* Changelog 5.5.1: create base for changelog.

* Fix typo and update release post link.

* Changelog: add #8167

* Changelog: add #8204

* Changelog: add #8129

* Changelog: add #8225

* Changelog: add #8219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Package] Sync [Pri] BLOCKER

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal error in admin - plugin_action_links

5 participants