Open Graph: do not pass image URL through esc_url#8177
Merged
Conversation
I added esc_url in #7246, but it seems to be causing encoding issues with images including special characters and being passed through Photon. Fixes 1305-gh-jpop-issues Fixes 1306-gh-jpop-issues
oskosk
approved these changes
Nov 20, 2017
zinigor
approved these changes
Nov 20, 2017
Contributor
zinigor
left a comment
There was a problem hiding this comment.
LGTM, let's revert for now.
zinigor
pushed a commit
that referenced
this pull request
Nov 20, 2017
I added esc_url in #7246, but it seems to be causing encoding issues with images including special characters and being passed through Photon. Fixes 1305-gh-jpop-issues Fixes 1306-gh-jpop-issues
Contributor
|
Ported to |
zinigor
added a commit
that referenced
this pull request
Nov 20, 2017
jeherve
pushed a commit
that referenced
this pull request
Nov 22, 2017
jeherve
pushed a commit
that referenced
this pull request
Nov 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
esc_urlin #7246, but it seems to be causing encoding issueswith images including special characters and being passed through Photon.
Fixes 1305-gh-jpop-issues
Fixes 1306-gh-jpop-issues