Skip to content

Google scripts: edit minified javascript#7912

Merged
jeherve merged 1 commit intoAutomattic:masterfrom
danielswiatek:master
Oct 4, 2017
Merged

Google scripts: edit minified javascript#7912
jeherve merged 1 commit intoAutomattic:masterfrom
danielswiatek:master

Conversation

@danielswiatek
Copy link
Copy Markdown
Contributor

@danielswiatek danielswiatek commented Oct 2, 2017

Fixes #7893

Changes proposed in this Pull Request:

Testing instructions:

Proposed changelog entry for your changes:

Copy link
Copy Markdown
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, the minified version seems to be almost the same at first glance, but it's three times smaller than the non-minified.
Thank you for contributing! Though I'd like to ask you to write at least a short PR description next time :)

@zinigor zinigor added [Feature] Sharing Post sharing, sharing buttons [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 2, 2017
@zinigor
Copy link
Copy Markdown
Contributor

zinigor commented Oct 2, 2017

Fixes #7893

@jeherve jeherve changed the title #7893 edit minified javascript Google scripts: edit minified javascript Oct 2, 2017
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merging as soon as the tests pass.

@jeherve jeherve merged commit 727c67d into Automattic:master Oct 4, 2017
@jeherve jeherve added [Status] Needs Changelog [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Changelog labels Oct 4, 2017
jeherve added a commit that referenced this pull request Oct 6, 2017
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Sharing Post sharing, sharing buttons Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google: Enqueue minified Javascript

5 participants