Skip to content

qa to develop#588

Merged
temaniarpit27 merged 56 commits into
developfrom
arpit/qa-to-develop
Nov 22, 2022
Merged

qa to develop#588
temaniarpit27 merged 56 commits into
developfrom
arpit/qa-to-develop

Conversation

@temaniarpit27

Copy link
Copy Markdown
Contributor

Description

Merged qa to develop
Added hardfork block number

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Added sprint length change + basefee denominator change hardfork block number

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

pratikspatil024 and others added 30 commits July 29, 2022 16:56
* changed name -> identity

* changed no-snapshot -> snapchot=true/false

* changed jsonrpc.corsdomain -> http.corsdomain

* changed jsonrpc.vhosts -> http.vhosts

* changed http/ws.modules to http/ws.api

* updated readme

* updated config_test

* make docs

* handelling string array flag, overwrite insted of append

* added 'Default' to SliceStringFlag

* added separate flags for corsdomain and vhosts for http, ws, graphql

* modified tests
…date defaults (#457)

* updated simple.json and simple.hcl

* added annotations for developer and grpc block

* added toml tags and simple.toml file

* added support for toml config files

* updated simple files toml, hcl, json

* added config.toml in builder/files and updated bor.service

* add dumpconfig command in cli for exporting configs

* update docs

* updated .goreleaser.yml (POS-651)

* changed --config to -config

* added test config for tests and fixed lint errors

* made fields of type big.int and time.Duration private, removed merge from dumpconfig, setting up default values to the Raw fields in dumpconfig, and fixed one lint error

* fixed lint errors (strange)

* lint fix

* private no-more, using '-' in name tags to ignore

* updated name tags, made c.configFile as a stringFlag (only one config file supported) and updated the merge logic in command.go -> Run()

* fix: set method for big.Int flags, added a TODO

* handeled bigInt and timeDuration type, bug fix in config_legacy, lint fix

* updated flags, consistent across flags.go and config.go

* fixed config test and updated test hcl, json config files

* updated config legacy test

* added test to check values of cmd flags, restructured Run in command.go, linter fix

* fix linters

* lint again

* changed 2 flags and assert -> require

* changed the 2 flags back

* updated correct congig.toml path and made mainnet default

* updated config.toml with new flags

* added sample config (toml) file

* removed sample-config.toml and added it in docs/config.md

Co-authored-by: Manav Darji <manavdarji.india@gmail.com>
Update qa branch for v0.3.0
* internal/cli: add support for removedb

* update docs

* internal/cli: use constant path, handle err
* handle snap sync mode switches

* fix linters
…toml and updated config name-tags (#486)

* removed package naoina/toml from dumpconfig and added BurntSushi/toml

* updated cmd/gethconfig.go
internal/cli/server: update default cli values

Co-authored-by: SHIVAM SHARMA <shivam691999@gmail.com>
This will potentially resolve "ERROR: network docker_default has active endpoints" problem
Changed 'requiredblocks' flag back to 'eth.requiredblocks'
* rpc: add finalized and safe block types

* ethclient: honour safe and finalized block requests

* fix: remove BlockByNumberWithoutTx function
* Added script to generate config.toml fromstart.sh (#518)

* added go and bash script to get config out of start.sh and updated flagset.go

* changed 'requiredblocks' flag back to 'eth.requiredblocks'

* updated script

* changed 'requiredblocks' flag back to 'eth.requiredblocks'

* updated tests, and removed requiredblocks from json and hcl

* addressed comments

* internal/cli/server: fix flag behaviour (#529)

* remove setting maxpeers to 0 for nodiscover flag

* set default prometheus and open-collector endpoint

* skip building grpc address from pprof address and port

* fix: linters

* fix and improve tests

* use loopback address for prometheus and open-collector endpoint

* add logs for prometheus and open-collector setup

* updated the script to handle prometheus-addr

* updated builder/files/config.toml

Co-authored-by: Pratik Patil <pratikspatil024@gmail.com>

Co-authored-by: Manav Darji <manavdarji.india@gmail.com>
* add support for bor.logs flag in new-cli

* handle bor.withoutheimdall flag commenting in conversion script
internal/cli: add support for bor.logs flag in new-cli (#541)
@temaniarpit27 temaniarpit27 requested a review from a team November 21, 2022 19:51
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Base: 56.74% // Head: 56.79% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (7ae5bce) compared to base (a3e7769).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #588      +/-   ##
===========================================
+ Coverage    56.74%   56.79%   +0.04%     
===========================================
  Files          607      607              
  Lines        70294    70305      +11     
===========================================
+ Hits         39888    39929      +41     
+ Misses       26983    26956      -27     
+ Partials      3423     3420       -3     
Impacted Files Coverage Δ
eth/sync.go 58.69% <ø> (ø)
internal/cli/server/command.go 6.77% <ø> (ø)
params/config.go 30.39% <ø> (ø)
params/version.go 36.84% <ø> (ø)
eth/filters/api.go 39.59% <0.00%> (-2.26%) ⬇️
les/utils/limiter.go 90.55% <0.00%> (-1.67%) ⬇️
consensus/ethash/algorithm.go 90.13% <0.00%> (-1.32%) ⬇️
core/rawdb/chain_iterator.go 58.38% <0.00%> (-1.25%) ⬇️
p2p/simulations/mocker.go 30.00% <0.00%> (-1.12%) ⬇️
eth/downloader/skeleton.go 76.45% <0.00%> (-0.51%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@temaniarpit27 temaniarpit27 merged commit b1739f6 into develop Nov 22, 2022
@temaniarpit27 temaniarpit27 deleted the arpit/qa-to-develop branch November 22, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants