Skip to content

Force load default tracers#563

Merged
cffls merged 3 commits into
0xPolygon:qafrom
cffls:qa
Oct 21, 2022
Merged

Force load default tracers#563
cffls merged 3 commits into
0xPolygon:qafrom
cffls:qa

Conversation

@cffls

@cffls cffls commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Description

Cherry-pick #560 into qa.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@0xsharma 0xsharma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* metrics: handle metrics flag from config in metrics.init()

* internal/cli/server: log for metrics enabling and misconfiguration
@codecov-commenter

codecov-commenter commented Oct 20, 2022

Copy link
Copy Markdown

Codecov Report

Base: 56.93% // Head: 57.01% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (5c5c992) compared to base (083c3fe).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa     #563      +/-   ##
==========================================
+ Coverage   56.93%   57.01%   +0.07%     
==========================================
  Files         598      601       +3     
  Lines       69073    69117      +44     
==========================================
+ Hits        39327    39406      +79     
+ Misses      26402    26363      -39     
- Partials     3344     3348       +4     
Impacted Files Coverage Δ
internal/cli/server/server.go 28.90% <0.00%> (-0.69%) ⬇️
metrics/metrics.go 10.95% <36.84%> (+9.17%) ⬆️
internal/cli/server/config.go 73.37% <100.00%> (+0.46%) ⬆️
p2p/enode/iter.go 88.34% <0.00%> (-2.92%) ⬇️
p2p/discover/table.go 82.48% <0.00%> (-1.83%) ⬇️
core/tx_pool.go 70.94% <0.00%> (-0.41%) ⬇️
trie/proof.go 73.94% <0.00%> (-0.36%) ⬇️
miner/worker.go 71.32% <0.00%> (-0.19%) ⬇️
les/downloader/downloader.go 75.26% <0.00%> (ø)
metrics/disk_nop.go 0.00% <0.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…gon#555)

* changed default of maxpeers from 200 to 50

* docs: update additional notes for new-cli

* docs: update additional notes for new-cli

* small bug fix in the script to fix shopt issue

Co-authored-by: Manav Darji <manavdarji.india@gmail.com>
@cffls cffls merged commit 439d588 into 0xPolygon:qa Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants