scripts: make config creation script independent of OS#538
Merged
Conversation
Codecov ReportBase: 56.84% // Head: 56.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #538 +/- ##
=========================================
Coverage 56.84% 56.84%
=========================================
Files 607 606 -1
Lines 69993 70121 +128
=========================================
+ Hits 39786 39861 +75
- Misses 26801 26834 +33
- Partials 3406 3426 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pratikspatil024
approved these changes
Oct 4, 2022
cffls
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some modifications in the getconfig script which is used to generate the toml config file according to the new-cli from an old (v0.2.x) start.sh to make it executable on Mac and Linux machines.
We've tried to make the solution simpler using some methods but that didn't work out. So, as of now, the current solution just includes if else statements at places to run commands depending on the current OS.
Reference Issue