eth, cli: prevent snap sync mode migration - v0.3.x#494
Merged
Conversation
JekaMas
approved these changes
Aug 17, 2022
temaniarpit27
approved these changes
Aug 17, 2022
Contributor
|
@manav2401 create a new PR from v0.2.16 and raise it against that as well |
pratikspatil024
approved these changes
Aug 17, 2022
marcello33
approved these changes
Aug 17, 2022
Codecov Report
@@ Coverage Diff @@
## develop #494 +/- ##
===========================================
- Coverage 56.94% 56.93% -0.01%
===========================================
Files 609 609
Lines 69987 69978 -9
===========================================
- Hits 39855 39844 -11
- Misses 26733 26744 +11
+ Partials 3399 3390 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cffls
pushed a commit
to cffls/bor
that referenced
this pull request
Aug 17, 2022
* handle snap sync mode switches * fix linters
cffls
pushed a commit
that referenced
this pull request
Aug 23, 2022
* handle snap sync mode switches * fix linters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen a couple of scenarios where some of our internal nodes have migrated to snap sync mode. Until we make it working fully, this PR will prevent that from happening.
It adds a preventive layer in the cli (old and new both) so that it's not enabled through flag and also handles cases where is migrates to snap sync.