Change diverged flags back to Geth's convention (POS-602)#451
Merged
Conversation
manav2401
reviewed
Jul 11, 2022
Codecov Report
@@ Coverage Diff @@
## develop #451 +/- ##
===========================================
+ Coverage 56.30% 56.36% +0.06%
===========================================
Files 597 600 +3
Lines 69014 69037 +23
===========================================
+ Hits 38855 38912 +57
+ Misses 26812 26798 -14
+ Partials 3347 3327 -20
Continue to review full report at Codecov.
|
cffls
approved these changes
Jul 12, 2022
Contributor
There was a problem hiding this comment.
LGTM. Notice that integration test failed. This is because the flags are changed, so bor couldn't correctly launch in CI. After this is merged, we will need to change start.sh in matic-cli here: https://github.com/maticnetwork/matic-cli/blob/v0.3.0-dev/src/setup/devnet/templates/docker/docker-bor-start.sh.njk
JekaMas
reviewed
Jul 13, 2022
JekaMas
approved these changes
Jul 13, 2022
cffls
pushed a commit
to cffls/bor
that referenced
this pull request
Jul 30, 2022
) * changed name -> identity * changed no-snapshot -> snapchot=true/false * changed jsonrpc.corsdomain -> http.corsdomain * changed jsonrpc.vhosts -> http.vhosts * changed http/ws.modules to http/ws.api * updated readme * updated config_test * make docs * handelling string array flag, overwrite insted of append * added 'Default' to SliceStringFlag * added separate flags for corsdomain and vhosts for http, ws, graphql * modified tests
cffls
pushed a commit
that referenced
this pull request
Aug 1, 2022
* changed name -> identity * changed no-snapshot -> snapchot=true/false * changed jsonrpc.corsdomain -> http.corsdomain * changed jsonrpc.vhosts -> http.vhosts * changed http/ws.modules to http/ws.api * updated readme * updated config_test * make docs * handelling string array flag, overwrite insted of append * added 'Default' to SliceStringFlag * added separate flags for corsdomain and vhosts for http, ws, graphql * modified tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following things:
Defaultfield to theSliceStringFlag.corsdomainandvhostsforhttp, ws, and graphql.POS-602