internal/cli/server: update default cli values#503
Merged
Conversation
manav2401
approved these changes
Aug 24, 2022
Member
|
Should we also change here and in launch repo? |
temaniarpit27
approved these changes
Aug 24, 2022
Contributor
isn't this deprecated? |
Codecov Report
@@ Coverage Diff @@
## develop #503 +/- ##
===========================================
+ Coverage 56.84% 56.95% +0.10%
===========================================
Files 607 610 +3
Lines 69977 69999 +22
===========================================
+ Hits 39781 39870 +89
+ Misses 26788 26724 -64
+ Partials 3408 3405 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
63f31bf to
eb16a3d
Compare
pratikspatil024
approved these changes
Aug 26, 2022
temaniarpit27
approved these changes
Aug 26, 2022
manav2401
approved these changes
Aug 26, 2022
manav2401
pushed a commit
that referenced
this pull request
Aug 26, 2022
internal/cli/server: update default cli values
manav2401
added a commit
that referenced
this pull request
Sep 1, 2022
internal/cli/server: update default cli values Co-authored-by: SHIVAM SHARMA <shivam691999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets some of the default flags in the new-cli referencing from bor v0.2.16 defaults.
Some of the flags changed are