copilot: Fix Copilot not respecting disable_ai setting#48495
Merged
osiewicz merged 2 commits intozed-industries:mainfrom Feb 11, 2026
Merged
copilot: Fix Copilot not respecting disable_ai setting#48495osiewicz merged 2 commits intozed-industries:mainfrom
disable_ai setting#48495osiewicz merged 2 commits intozed-industries:mainfrom
Conversation
Previously, the Copilot language server would continue running even when `disable_ai: true` was set in settings. This change ensures Copilot properly responds to the `disable_ai` setting: - Add `disable_ai` check in `start_copilot()` to prevent starting when AI is disabled - Modify the `SettingsStore` observer to shut down the running language server when `disable_ai` changes from false to true - Add tests for all scenarios: - Copilot doesn't start when `disable_ai` is true - Copilot stops when `disable_ai` becomes true - Copilot can start again when `disable_ai` becomes false
Member
|
Thank you! |
morgankrey
added a commit
that referenced
this pull request
Feb 19, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied documentation from: - PR #48908: git diff view toggle + default setting - PR #48909: agent mode cycling keybinding - PR #48910: diff view nomenclature standardization - PR #48912: split diff for everyone - PR #48930: terminal welcome screen fix - PR #44794: JSON/YAML schema paths - PR #48763: Python environments in REPL - PR #45073: zed --add terminal panels - PR #48495: Python Windows path handling - PR #49374: type on search default
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied documentation from: - PR #48908: git diff view toggle + default setting - PR #48909: agent mode cycling keybinding - PR #48910: diff view nomenclature standardization - PR #48912: split diff for everyone - PR #48930: terminal welcome screen fix - PR #44794: JSON/YAML schema paths - PR #48763: Python environments in REPL - PR #45073: zed --add terminal panels - PR #48495: Python Windows path handling - PR #49374: type on search default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48274
Previously, the Copilot language server would continue running even when
disable_ai: truewas set in settings. This change ensures Copilot properly responds to thedisable_aisetting:disable_aicheck instart_copilot()to prevent starting when AI is disabledSettingsStoreobserver to shut down the running language server whendisable_aichanges from false to truedisable_aiis truedisable_aibecomes truedisable_aibecomes falseRelease Notes: