languages: Fix local path of JSON and YAML schemas#44794
Merged
ConradIrwin merged 2 commits intozed-industries:mainfrom Feb 12, 2026
Merged
languages: Fix local path of JSON and YAML schemas#44794ConradIrwin merged 2 commits intozed-industries:mainfrom
ConradIrwin merged 2 commits intozed-industries:mainfrom
Conversation
b75405f to
a81787a
Compare
bbf0ec0 to
68f7b22
Compare
Contributor
Author
|
This is ready for review. |
b60c1e2 to
dfa5e62
Compare
Contributor
Author
|
@miguelraz @maxdeviant Do you have time to review this PR? Thanks! |
Member
|
@belltoy thanks for this, and sorry for the glacial reply. I think this functionality looks good, but:
|
dfa5e62 to
8546b80
Compare
Contributor
Author
|
Thank you for reviewing, @ConradIrwin. You're right. I've updated this patch. |
8546b80 to
683fdc5
Compare
Member
|
thanks! I was confused by the naming Going to hit merge on this. |
morgankrey
added a commit
that referenced
this pull request
Feb 19, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied documentation from: - PR #48908: git diff view toggle + default setting - PR #48909: agent mode cycling keybinding - PR #48910: diff view nomenclature standardization - PR #48912: split diff for everyone - PR #48930: terminal welcome screen fix - PR #44794: JSON/YAML schema paths - PR #48763: Python environments in REPL - PR #45073: zed --add terminal panels - PR #48495: Python Windows path handling - PR #49374: type on search default
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied documentation from: - PR #48908: git diff view toggle + default setting - PR #48909: agent mode cycling keybinding - PR #48910: diff view nomenclature standardization - PR #48912: split diff for everyone - PR #48930: terminal welcome screen fix - PR #44794: JSON/YAML schema paths - PR #48763: Python environments in REPL - PR #45073: zed --add terminal panels - PR #48495: Python Windows path handling - PR #49374: type on search default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30938
Release Notes:
This patch follows the vscode LSP client logic, see
jsonClient.ts. Theurlof the JSON schemas settings and the YAML schemas settings should be resolved to an absolute path in the LSP client when it is submitted to the server.