json_schema_store: Include available LSP adapters in settings schema by baeseokjae · Pull Request #46766 · zed-industries/zed

baeseokjae · 2026-01-14T06:37:56Z

Summary

Fix "Property ty is not allowed" warning in settings.json for LSP adapters registered via register_available_lsp_adapter()
Add available_lsp_adapter_names() method to include these adapters in schema generation
Support initialization_options schema lookup for available adapters

Problem

LSP adapters registered via register_available_lsp_adapter() were not included in the settings JSON schema. This caused validation warnings like:

Property ty is not allowed

Even though ty is a built-in Python language server that works correctly.

Affected adapters:

ty, py, python-lsp-server
eslint, vtsls, typescript-language-server
tailwindcss-language-server, tailwindcss-intellisense-css

Solution

Schema generation now queries both:

all_lsp_adapters() - adapters bound to specific languages
available_lsp_adapter_names() - adapters enabled via settings (new)

Related: #43104, #45928

Release Notes:

Fixed an issue where not all LSP adapters would be suggested for completion, or recognized as valid in settings.json

Fix "Property `ty` is not allowed" warning in settings.json for LSP adapters registered via `register_available_lsp_adapter()`. Previously, only adapters registered via `register_lsp_adapter()` were included in the settings schema. This caused validation warnings for adapters like `ty`, `pylsp`, `eslint`, and `tailwindcss-language-server`. Changes: - Add `available_lsp_adapter_names()` method to LanguageRegistry - Include available adapter names in settings schema generation - Support initialization_options schema lookup for available adapters Fixes zed-industries#46556

cla-bot · 2026-02-02T16:17:52Z

We require contributors to sign our Contributor License Agreement, and we don't have @baeseokjae on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot · 2026-02-02T16:21:05Z

We require contributors to sign our Contributor License Agreement, and we don't have @baeseokjae on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

probably-neb · 2026-02-02T16:23:29Z

I made some fixes for the PR. Sorry for the delay. Please follow the cla instructions above, and I'll merge this!

lingyaochu · 2026-02-02T16:43:08Z

crates/json_schema_store/src/json_schema_store.rs

@@ -224,6 +225,9 @@ async fn resolve_dynamic_schema(
                .all_lsp_adapters()
                .into_iter()
                .find(|adapter| adapter.name().as_ref() as &str == lsp_name)
+                .or_else(|| {
+                    languages.load_available_lsp_adapter(&LanguageServerName::from(lsp_name))


I'm concerned about calling load_available_lsp_adapter here. It is not a pure "getter" for information; it has significant side effects and directly mutates the state of the language server module.

In my view, the settings schema resolution should be decoupled from the LSP lifecycle. We should only be querying the existing state rather than triggering a "load" action, which could lead to unintended consequences.

@lingyaochu thanks for the review.

Just to clarify, load_available_lsp_adapter here doesn’t really act as a pure accessor, but it also doesn’t mutate shared state. It only takes a read lock and creates a temporary instance for schema lookup, then drops it.

For available adapters like ty, eslint, or pylsp, this is basically the only way to access their schemas today since they’re lazy-loaded and not part of all_lsp_adapters.

I agree that having schema resolution go through a “load” path isn’t ideal. That feels like something better handled as a separate issue later on. For this PR though, sticking with the current approach seems reasonable to me and I don’t see this causing issues in practice.

Thanks for the clarification! I misunderstood how load_available_lsp_adapter worked under the hood. Given that it doesn't mutate shared state and is necessary for lazy-loaded adapters, this approach makes sense for now. I'm happy with the fix!

baeseokjae · 2026-02-04T00:20:46Z

@cla-bot check

cla-bot · 2026-02-04T00:20:49Z

We require contributors to sign our Contributor License Agreement, and we don't have @baeseokjae on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot · 2026-02-04T00:20:50Z

The cla-bot has been summoned, and re-checked this pull request!

baeseokjae · 2026-02-04T00:31:57Z

@probably-neb I’ve signed the CLA before, but I changed username recently and the bot doesn’t seem to recognize it.
Previous username: BaeSeokJae

Could you take a quick look when you get a chance? Thanks!

MrSubidubi · 2026-02-11T18:58:56Z

@baeseokjae Can I ask you to re-sign the CLA? We track this only based on the current username, so would be nice if you could just sign it again. Thanks!

baeseokjae · 2026-02-12T01:22:31Z

@cla-bot check

cla-bot · 2026-02-12T01:22:37Z

The cla-bot has been summoned, and re-checked this pull request!

Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 Generated with script/docs-suggest-publish for human review in draft PR.

Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.

Auto-applied documentation from: - PR #48542: Bedrock extended context window - PR #46766: LSP adapters in settings schema - PR #47754: VSCode tasks.json label generation Skipped (no target file exists): - PR #49069: panel zoom state persistence Already documented from prior batches: - PR #48807, PR #44506, PR #49051, PR #48842, PR #48851, PR #48736

Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.

Auto-applied documentation from: - PR #48542: Bedrock extended context window - PR #46766: LSP adapters in settings schema - PR #47754: VSCode tasks.json label generation Skipped (no target file exists): - PR #49069: panel zoom state persistence Already documented from prior batches: - PR #48807, PR #44506, PR #49051, PR #48842, PR #48851, PR #48736

cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 14, 2026

zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Jan 14, 2026

baeseokjae force-pushed the fix/lsp-ty-schema-not-recognized branch from 5f810dc to d191727 Compare January 14, 2026 06:41

SomeoneToIgnore assigned probably-neb Jan 14, 2026

baeseokjae force-pushed the fix/lsp-ty-schema-not-recognized branch from d191727 to 148ea05 Compare January 15, 2026 05:15

baeseokjae and others added 2 commits February 2, 2026 11:07

avoid contains

54ff93b

probably-neb force-pushed the fix/lsp-ty-schema-not-recognized branch from 148ea05 to 54ff93b Compare February 2, 2026 16:17

cla-bot bot removed the cla-signed The user has signed the Contributor License Agreement label Feb 2, 2026

unused import

23e5f7a

lingyaochu reviewed Feb 2, 2026

View reviewed changes

rgreminger mentioned this pull request Feb 9, 2026

Add language server workspace configuration JuliaEditorSupport/zed-julia#56

Merged

cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 12, 2026

probably-neb merged commit c1907c9 into zed-industries:main Feb 12, 2026
36 checks passed

Uh oh!

Conversation

baeseokjae commented Jan 14, 2026 • edited by probably-neb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Uh oh!

cla-bot bot commented Feb 2, 2026

Uh oh!

cla-bot bot commented Feb 2, 2026

Uh oh!

probably-neb commented Feb 2, 2026

Uh oh!

lingyaochu Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

baeseokjae Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

lingyaochu Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

baeseokjae commented Feb 4, 2026

Uh oh!

cla-bot bot commented Feb 4, 2026

Uh oh!

cla-bot bot commented Feb 4, 2026

Uh oh!

baeseokjae commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrSubidubi commented Feb 11, 2026

Uh oh!

baeseokjae commented Feb 12, 2026

Uh oh!

cla-bot bot commented Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

baeseokjae commented Jan 14, 2026 •

edited by probably-neb

Loading

baeseokjae commented Feb 4, 2026 •

edited

Loading