search: Support brace syntax in project search include/exclude patterns #47860
Merged
SomeoneToIgnore merged 2 commits intozed-industries:mainfrom Feb 12, 2026
Merged
Conversation
0dc6ec3 to
86fc3c9
Compare
Contributor
Author
|
Hi @MrSubidubi how are you today? |
KuSh
reviewed
Jan 28, 2026
|
|
||
| for (index, char) in text.char_indices() { | ||
| match char { | ||
| '{' => brace_depth += 1, |
Contributor
There was a problem hiding this comment.
I think, escaping should be taken into account, for {, } and ,
See bash documentation:
A ‘{’ or ‘,’ may be quoted with a backslash to prevent its being considered part of a brace expression.
Source: https://www.gnu.org/software/bash/manual/html_node/Brace-Expansion.html
Contributor
Author
There was a problem hiding this comment.
I updated, please review again
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
Thank you, is this good to merge? |
Contributor
I'm not part of the project. You'll need an approve from a reviewer |
SomeoneToIgnore
approved these changes
Feb 12, 2026
Contributor
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Thank you a lot both of you for the cooperation, this looks very finished now, happy to merge.
Contributor
Author
|
Thank you for merging, @SomeoneToIgnore |
Contributor
|
Feel free to work on anything you want to change, without the assignment, that's also perfectly fine. |
morgankrey
added a commit
that referenced
this pull request
Feb 19, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied documentation from: - PR #48619: agent single_file_review default change - PR #48978: enriched symbol names in outline - PR #49015: audio device selection for collab - PR #47095: MCP error handling - PR #47475: OpenRouter default model requirement Skipped (already documented): - PR #49139, PR #48780, PR #48988, PR #47860
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied documentation from: - PR #48619: agent single_file_review default change - PR #48978: enriched symbol names in outline - PR #49015: audio device selection for collab - PR #47095: MCP error handling - PR #47475: OpenRouter default model requirement Skipped (already documented): - PR #49139, PR #48780, PR #48988, PR #47860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47527
Summary
The include/exclude filters in Project Search now support standard glob brace syntax like
{a,b}.Before:
crates/{search,project}/**/file.rswould error with "unclosed alternate group"After: Pattern correctly matches files in both
crates/search/andcrates/project/Implementation
Added
split_glob_patterns()function that splits by comma only when not inside braces, preserving the{a,b}syntax thatglobsetnatively supports.Release Notes:
{a,b}glob syntax in project search include/exclude filtersHere is the screenshot of before and after.
Before:
After:
