language_models: Add image support for Bedrock#47673
Merged
benbrandt merged 2 commits intozed-industries:mainfrom Feb 13, 2026
Merged
language_models: Add image support for Bedrock#47673benbrandt merged 2 commits intozed-industries:mainfrom
benbrandt merged 2 commits intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @Gitarth on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Contributor
|
( I know I'm not a maintainer ) but it does look good to me. Follows the Bedrock patterns, the only concern I have is forcing all images to be read as PNGs feels a bit awkward -- but should work fine. |
Contributor
Author
|
Thanks for the review! |
Collaborator
|
Can you rebase this against main or bring in a merge commit? I'll bring this up to zed maintainers to have a look at it. |
8b53488 to
a059375
Compare
Contributor
Author
|
Applied rustfmt to resolve the check_script error in the tests_pass runner. |
morgankrey
added a commit
that referenced
this pull request
Feb 19, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied documentation from: - PR #47673: Bedrock image support - PR #49098: Agent max tokens error messaging - PR #49622: Gemini 3.1 Pro model - PR #49554: OpenAI-compatible edit prediction - PR #49710: Git diff review button - PR #49732: Subagent tool updates - PR #49788: ETW profiling on Windows Skipped (no target file/self-explanatory): - PR #49094: Add project to workspace button
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied queued documentation suggestions from: - PR #48908 - PR #48909 - PR #48910 - PR #48912 - PR #48930 - PR #44794 - PR #48763 - PR #45073 - PR #48495 - PR #49374 - PR #49139 - PR #48780 - PR #48619 - PR #48978 - PR #48962 - PR #48988 - PR #47860 - PR #49015 - PR #47095 - PR #47475 - PR #48542 - PR #46766 - PR #47754 - PR #48807 - PR #44506 - PR #49051 - PR #49069 - PR #48842 - PR #48851 - PR #48736 - PR #47673 - PR #49094 - PR #49098 - PR #49622 - PR #49554 - PR #49710 - PR #49716 - PR #49732 - PR #49788 - PR #49876 - PR #49902 - PR #49910 - PR #49390 - PR #50027 Generated with script/docs-suggest-publish for human review in draft PR.
morgankrey
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-applied documentation from: - PR #47673: Bedrock image support - PR #49098: Agent max tokens error messaging - PR #49622: Gemini 3.1 Pro model - PR #49554: OpenAI-compatible edit prediction - PR #49710: Git diff review button - PR #49732: Subagent tool updates - PR #49788: ETW profiling on Windows Skipped (no target file/self-explanatory): - PR #49094: Add project to workspace button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #N/A (no existing issue - implemented to enable image input for Bedrock models)
This PR enables the "@" image mention feature for Bedrock models that support vision capabilities.
Changes:
supports_images()method to BedrockModelenumMessageContent::Imagehandling to convert base64 images to Bedrock's expected formatSupported models: Claude 3/3.5/4 family, Amazon Nova Pro/Lite, Meta Llama 3.2 Vision, Mistral Pixtral
Release Notes: