Skip to content

cmake: use CMAKE_INSTALL_PREFIX instead of custom install command#391

Merged
yorkie merged 1 commit intomasterfrom
cmake/xcode
Oct 25, 2018
Merged

cmake: use CMAKE_INSTALL_PREFIX instead of custom install command#391
yorkie merged 1 commit intomasterfrom
cmake/xcode

Conversation

@legendecas
Copy link
Copy Markdown
Contributor

@legendecas legendecas commented Oct 25, 2018

adjusts sub-projects installation process

  • npm test passes

@legendecas legendecas requested review from qile222 and yorkie October 25, 2018 09:18
Copy link
Copy Markdown
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorkie yorkie merged commit ddf6ca7 into master Oct 25, 2018
@yorkie yorkie deleted the cmake/xcode branch October 25, 2018 22:03
qile222 pushed a commit that referenced this pull request Oct 27, 2018
* master:
  build: use CMAKE_INSTALL_PREFIX instead of custom install command (#391)
  child_process: introduce binary protocol to optimizing performance (#393)
  iotjs: cache parsed dump table for error.stack at runtime (#392)
  jerry: merge a59cf4f from upstream to optimize the function call (#381)
  promise: optimize the performance on .then and static resolve (#385)
  jerry: set prototype/constructor for external functions (#386)
  process: add shebang parser supports (#379)
  napi: fix complete callback segv/ticks on async-work (#380)
  jerry: pass regression-test-issue-2105 for heapdump (#382)
  tls, mqtts: fix connection not be actively disconnected (#375)
  websocket: fix the crash due to http exception (#376)
  process: add signal events support (#372)
legendecas pushed a commit that referenced this pull request Oct 31, 2018
* build: use CMAKE_INSTALL_PREFIX instead of custom install command (#391)

* build: add dependencies for iotjs.cmake which depends on others (#396)

Within some parallel builds, it occasionally gets a build error on
libmqtt_packet depenedency.

* events: cannot read property 'newListener' of undefined (#397)

* tools: clang-format-7 on travis-ci (#398)

* mqtt: update event trigger timing (#400)

* fix/mqtt-connect-event

* remove abundant error listener

* n-api: code is optional on create error (#399)

* v0.10.13: bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants