Skip to content

build: add dependencies for iotjs.cmake which depends on others#396

Merged
legendecas merged 1 commit intomasterfrom
fix/parallel-build
Oct 29, 2018
Merged

build: add dependencies for iotjs.cmake which depends on others#396
legendecas merged 1 commit intomasterfrom
fix/parallel-build

Conversation

@yorkie
Copy link
Copy Markdown
Member

@yorkie yorkie commented Oct 27, 2018

Within some parallel builds, it occasionally gets a build error on libmqtt_packet depenedency.

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added

Within some parallel builds, it occasionally gets a build error on
libmqtt_packet depenedency.
@yorkie yorkie force-pushed the fix/parallel-build branch from 021a7bb to 845e386 Compare October 27, 2018 15:46
Copy link
Copy Markdown
Contributor

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit d5af55f into master Oct 29, 2018
@legendecas legendecas deleted the fix/parallel-build branch October 29, 2018 07:04
yorkie added a commit that referenced this pull request Oct 31, 2018
Within some parallel builds, it occasionally gets a build error on
libmqtt_packet depenedency.
legendecas pushed a commit that referenced this pull request Oct 31, 2018
* build: use CMAKE_INSTALL_PREFIX instead of custom install command (#391)

* build: add dependencies for iotjs.cmake which depends on others (#396)

Within some parallel builds, it occasionally gets a build error on
libmqtt_packet depenedency.

* events: cannot read property 'newListener' of undefined (#397)

* tools: clang-format-7 on travis-ci (#398)

* mqtt: update event trigger timing (#400)

* fix/mqtt-connect-event

* remove abundant error listener

* n-api: code is optional on create error (#399)

* v0.10.13: bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants