Skip to content

events: cannot read property 'newListener' of undefined#397

Merged
yorkie merged 1 commit intomasterfrom
fix/events
Oct 29, 2018
Merged

events: cannot read property 'newListener' of undefined#397
yorkie merged 1 commit intomasterfrom
fix/events

Conversation

@legendecas
Copy link
Copy Markdown
Contributor

@legendecas legendecas commented Oct 29, 2018

  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added

fixes an edge issue:

var obj = {}
EventEmitter.prototype.on.apply(obj, ['foobar'])

as this is not an officially documented usage, test case is not included by intent.

Copy link
Copy Markdown
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorkie yorkie merged commit 42a4384 into master Oct 29, 2018
@yorkie yorkie deleted the fix/events branch October 29, 2018 09:21
legendecas pushed a commit that referenced this pull request Oct 31, 2018
* build: use CMAKE_INSTALL_PREFIX instead of custom install command (#391)

* build: add dependencies for iotjs.cmake which depends on others (#396)

Within some parallel builds, it occasionally gets a build error on
libmqtt_packet depenedency.

* events: cannot read property 'newListener' of undefined (#397)

* tools: clang-format-7 on travis-ci (#398)

* mqtt: update event trigger timing (#400)

* fix/mqtt-connect-event

* remove abundant error listener

* n-api: code is optional on create error (#399)

* v0.10.13: bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants