Skip to content

jerry: merge a59cf4f from upstream to optimize the function call#381

Merged
yorkie merged 1 commit intomasterfrom
jerry/rework-function-call
Oct 23, 2018
Merged

jerry: merge a59cf4f from upstream to optimize the function call#381
yorkie merged 1 commit intomasterfrom
jerry/rework-function-call

Conversation

@yorkie
Copy link
Copy Markdown
Member

@yorkie yorkie commented Oct 20, 2018

This merges the upstream PR(jerryscript-project/jerryscript#2414) which optimizes the following:

Furthermore add a construct flag, which disallows calling certain functions without new. Constructing bound arrow functions correctly throws error now.

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added

BTW, jerryscript-project/jerryscript@65ae949 is valuable to merge into our own fork, either.

Furthermore add a construct flag, which disallows calling certain
functions without new. Constructing bound arrow functions correctly
throws error now.

Author: Zoltan Herczeg<zherczeg.u-szeged@partner.samsung.com>
PR-URL: jerryscript-project/jerryscript#2414
@yorkie yorkie added the jerry label Oct 20, 2018
@yorkie
Copy link
Copy Markdown
Member Author

yorkie commented Oct 20, 2018

Because the current jerry tests are fails, so just run test locally with the following result:

[64/ 369] build/tests/jerry_tests-es2015_subset-debug/bin/jerry tests/jerry/es2015/regression-test-issue-2414.js: PASS

@legendecas
Copy link
Copy Markdown
Contributor

Looks like #294 doesn't get resolved in this function call rework?

@legendecas legendecas self-requested a review October 21, 2018 06:36
@yorkie
Copy link
Copy Markdown
Member Author

yorkie commented Oct 21, 2018

Looks like #294 doesn't get resolved in this function call rework?

This doesn't fixes that, but I have fixed at #386.

Copy link
Copy Markdown
Contributor

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorkie yorkie merged commit 426c37d into master Oct 23, 2018
@yorkie yorkie deleted the jerry/rework-function-call branch October 23, 2018 06:51
yorkie added a commit that referenced this pull request Oct 24, 2018
Furthermore add a construct flag, which disallows calling certain
functions without new. Constructing bound arrow functions correctly
throws error now.

Author: Zoltan Herczeg<zherczeg.u-szeged@partner.samsung.com>
PR-URL: jerryscript-project/jerryscript#2414
qile222 pushed a commit that referenced this pull request Oct 27, 2018
* master:
  build: use CMAKE_INSTALL_PREFIX instead of custom install command (#391)
  child_process: introduce binary protocol to optimizing performance (#393)
  iotjs: cache parsed dump table for error.stack at runtime (#392)
  jerry: merge a59cf4f from upstream to optimize the function call (#381)
  promise: optimize the performance on .then and static resolve (#385)
  jerry: set prototype/constructor for external functions (#386)
  process: add shebang parser supports (#379)
  napi: fix complete callback segv/ticks on async-work (#380)
  jerry: pass regression-test-issue-2105 for heapdump (#382)
  tls, mqtts: fix connection not be actively disconnected (#375)
  websocket: fix the crash due to http exception (#376)
  process: add signal events support (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants