Conversation
Contributor
|
Does invocation of |
Member
Author
|
The Node.js documentation about
So the answer should be yes, |
Member
Author
|
@legendecas Added an issue #373 about the current wrong at |
legendecas
reviewed
Oct 16, 2018
test/run_pass/test_signal_simple.js
Outdated
| var signals = require('constants').os.signals; | ||
|
|
||
| function testSignal(type) { | ||
| process.once(type, function(signal) { |
Contributor
There was a problem hiding this comment.
may use common.mustCall to ensure invocation of the callback
68fa133 to
c300f5d
Compare
qile222
approved these changes
Oct 16, 2018
Contributor
|
LGTM |
yorkie
added a commit
that referenced
this pull request
Oct 16, 2018
qile222
pushed a commit
that referenced
this pull request
Oct 27, 2018
* master: build: use CMAKE_INSTALL_PREFIX instead of custom install command (#391) child_process: introduce binary protocol to optimizing performance (#393) iotjs: cache parsed dump table for error.stack at runtime (#392) jerry: merge a59cf4f from upstream to optimize the function call (#381) promise: optimize the performance on .then and static resolve (#385) jerry: set prototype/constructor for external functions (#386) process: add shebang parser supports (#379) napi: fix complete callback segv/ticks on async-work (#380) jerry: pass regression-test-issue-2105 for heapdump (#382) tls, mqtts: fix connection not be actively disconnected (#375) websocket: fix the crash due to http exception (#376) process: add signal events support (#372)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAdded the signal events support by Node.js API, and this is mainly the precondition of simplifying the progress of taking the snapshot, and other debugger/dump usages.
/cc @lolBig @legendecas @fighterkin @algebrait