Release 1.46.0 by fluiddot · Pull Request #3078 · wordpress-mobile/gutenberg-mobile

fluiddot · 2021-02-01T14:04:03Z

Release for Gutenberg Mobile 1.46.0

Related PRs

Gutenberg: Mobile Release v1.46.0 WordPress/gutenberg#28634
WPAndroid: Integrate gutenberg-mobile release 1.46.0 WordPress-Android#13927
WPiOS: Integrate gutenberg-mobile release 1.46.0 WordPress-iOS#15752

Extra PRs that Landed After the Release Was Cut

Correct condition in setting blockWidth - Correct blockWidth #3079
Fix height of the bottom-sheet after using back button - [FIX] Bottom-sheet height after using back button #3080
Audio Block - I - Audio Block - I #2854
Enable Audio Block - Enable Audio Block #3070
Move custom indicator to be rendered above the colors - Move custom indicator to be rendered above the colors #3098
Fix download button in File block - Fix download button in File block #3102

Changes

Correct full width buttons - Correct full width buttons #3077
Disable Unsupported block editor for Reusable blocks - Disable Unsupported block editor for Reusable blocks #3067
Audio Block - Audio Block - I #2854
Add proper handling for single use blocks such as the more block - Add support for "multiple": false block types #3042
Reusable blocks - Present block content (preview mode) - Reusable blocks - Present block content (preview mode) #2953
Add Array.prototype.flatMap polyfill - Add Array.prototype.flatMap polyfill #3035

Test plan

Use the main WP apps to test the changes above.
Smoke test the main WP apps for general writing flow.

Release Submission Checklist

Approve and run optional Android and iOS UI tests
Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
Bundle package of the release is updated.

…blocks Reusable blocks - Present block content (preview mode)

Bumps [jetpack](https://github.com/Automattic/jetpack) from `6f07c39` to `60f41b6`. - [Release notes](https://github.com/Automattic/jetpack/releases) - [Commits](Automattic/jetpack@6f07c39...60f41b6) Signed-off-by: dependabot[bot] <support@github.com>

Add Array.prototype.flatMap polyfill

…o_develop Merge release 1.45.0 to develop

…jetpack-60f41b6 Bump jetpack from `6f07c39` to `60f41b6`

Add support for `"multiple": false` block types

Correct blockWidth

Audio Block - I

…eusable-blocks Disable Unsupported block editor for Reusable blocks

fluiddot · 2021-02-02T12:52:54Z

ceyhun · 2021-02-02T14:07:59Z

fluiddot · 2021-02-02T14:11:27Z

Note: The image behind "Join us!" was not copied over but this might be the current case because the How We Work page was recently updated. I tried copying https://wordpress.com/blog/2021/01/25/building-single-page-websites-on-wordpress-com/ instead and images were also pasted.

I also noticed this issue but I think it's not copying it because the image is a background image.

fluiddot · 2021-02-02T14:15:13Z

Quote Block: Split by pressing enter to create a new line at the end of citation and merge back pressing backspace -> Cursor jumps back to quote instead of citation.
Pullquote Block: Split by pressing enter to create a new line at the end of citation and merge back pressing backspace -> Pullquote block is selected instead of cursor moving back to citation.

I also reproduced this issue on Android but I didn't report it because there's already an issue that is linked in the test cases. If it's happening on iOS too we could update it including the new case.

ceyhun · 2021-02-02T14:58:31Z

I also reproduced this issue on Android but I didn't report it because there's already an issue that is linked in the test cases. If it's happening on iOS too we could update it including the new case.

I think it's not the same issue. This happens when merging a paragraph block into quote block. I just tested on WPiOS 16.6.20210129 and 16.5.20210129 and it's also present there, so it's not a regression in this version. I'll create separate issues for these.

fluiddot · 2021-02-02T15:05:33Z

I also reproduced this issue on Android but I didn't report it because there's already an issue that is linked in the test cases. If it's happening on iOS too we could update it including the new case.

I think it's not the same issue. This happens when merging a paragraph block into quote block. I just tested on WPiOS 16.6.20210129 and 16.5.20210129 and it's also present there, so it's not a regression in this version. I'll create separate issues for these.

Oh sorry, I misunderstood the steps, right, it's not the same issue. By the way, I've just checked this on Android and it's happening there too.

ceyhun · 2021-02-02T16:14:57Z

Quote issue is same on the web, it might be an expected behavior. But not the Pullquote one, I've created an issue for this: #3089

chipsnyder · 2021-02-02T19:54:50Z

enejb · 2021-02-02T23:42:47Z

fluiddot · 2021-02-03T10:33:28Z

After the first round of manual tests we found so far the following issues:

iOS & Android

Quote block splits on new line ✅

Description

Tapping enter on an empty line splits the block.

Next steps

This was checked on the web version and this behaviour is expected so we shouldn't consider this an issue.

Image not copied when pasting formatted text copied from website ✅

Description

The image behind "Join us!" was not copied over but this might be the current case because the How We Work page was recently updated. When copying content from other site like https://wordpress.com/blog/2021/01/25/building-single-page-websites-on-wordpress-com/, the images were also pasted.

Next steps

The image from How We Work page is not copied because it's rendered as a background images so we shouldn't consider this an issue.

Quote Block - Wrong cursor position when merging back ✅

Description

Split by pressing enter to create a new line at the end of citation and merge back pressing backspace -> Cursor jumps back to quote instead of citation.

Next steps

This was checked on the web version and this behaviour is expected so we shouldn't consider this an issue.

Pullquote Block - Wrong cursor position when merging back 🟡

Description

Split by pressing enter to create a new line at the end of citation and merge back pressing backspace -> Pullquote block is selected instead of cursor moving back to citation.

Next steps

This behaviour is not expected, however it's also reproducible on released versions like WPiOS 16.6 and 16.5 and WPAndroid 16.6 so this version is not introducing it.

An issue has been created to address it.

MediaText Block - Vertical alignment options are no longer inlined 🟡

Description

The screenshot of the test case shows the vertical alignment options as inlined, looks like this has been changed in a recent version.

Next steps

If this change was made on purpose we should update the screenshot.

Only iOS

None 🎊 .

Only Android

Text flickering when removing a line on some multiline blocks 🟡

Description

When a line is deleted in some multiline blocks, specifically the Quote, Preformatted and Verse, the text lines position moves some pixels down for a frame and then goes back to the original position.

Next steps

This was checked on latest release candidate version (16.6-rc-2) and this issue is also reproducible there so this version is not introducing it.

An issue has been created to address it.

Colors Segmented Controls crash 🟢 (fixed by @lukewalczak)

Fixed in gutenberg PR 🎊 .

Description

When switching between the gradient and solid colour really quick the app crashes.

Here are the related steps.

Next steps

This was checked on release candidate version (16.6-rc-2) and this issue is also reproducible there so this version is not introducing it.

Since this is producing a crash it would be nice to fix it in this version. An issue has been created to address it as soon as possible.

fluiddot · 2021-02-03T10:58:35Z

👎 Scroll color palette to the end - steps
It doesn't scroll to the end for me

👋 @enejb I tried to reproduce the issue you commented but so far it's not happening to me, could you try it again?

I did the test on a Samsung Galaxy S20 FE 5G and build 93717.

scroll-color-palette-end-android.mp4

fluiddot · 2021-02-04T11:25:22Z

Status update

Colors Segmented Controls crash has been fixed 🎊
The issues spotted during the first round of manual tests have been considered as non release blockers so they will addressed in the future:
- Pullquote Block - Wrong cursor position when merging back - Tapping backspace to merge a paragraph into pullquote block dismisses keyboard #3089
- MediaText Block - Vertical alignment options are no longer inlined - https://github.com/wordpress-mobile/gutenberg-mobile/issues/3103
- Text flickering when removing a line on some multiline blocks - Text flickering when removing a line on some multiline blocks #3096
The issue on Android related to "Scroll color palette to the end - It doesn't scroll to the end for me" has been tested but I couldn't reproduce it, at least following the test case instructions. However I managed to reproduce it when testing gradient colors, I've opened an issue to address it in the future.

Next step will be to:

Test the fix related to "Colors Segmented Controls crash" ✅
Test the fix related to "Fix download button in File block" ✅
Run a second round of manual tests in both platforms (iOS and Android).
Review the release PRs

fluiddot · 2021-02-04T15:48:06Z

ceyhun · 2021-02-04T17:42:38Z

enejb · 2021-02-04T21:13:57Z

👋 @fluiddot. I just tested it again and it looks like both Colour issues (Crash and not advancing to the end) are fixed for me. 🥳

fluiddot · 2021-02-05T08:56:49Z

Status update

The second round of manual tests is finished, no critical issues have been found and latest changes have been verified 🎊 .

Here are the list of issues found in this release that should be addressed in the future:

Pullquote Block - Wrong cursor position when merging back - Tapping backspace to merge a paragraph into pullquote block dismisses keyboard #3089
MediaText Block - Vertical alignment options are no longer inlined - Update Dark Mode - Test Cases - TC003 screenshot test-cases#67
Text flickering when removing a line on some multiline blocks - Text flickering when removing a line on some multiline blocks #3096
Switching from Solid to Gradient doesn't scroll to end when having customised gradient - Switching from Solid to Gradient doesn't scroll to end when having customised gradient #3104
Heading block stops being rendered as a header when deleting the first word - Heading block stops being rendered as a header when deleting the first word #3106

Next steps

Review and approve the PRs of the release branches.
Run the last day steps for merging the release into the WordPress app repositories.

ceyhun

Things are looking good

fluiddot and others added 30 commits January 19, 2021 13:36

Add reusable block action button hook

f0e8ba5

Updated gutenberg ref

5b392cd

Updated gutenberg ref

1612f46

Updated gutenberg ref

c0a5910

Merge pull request #2953 from wordpress-mobile/2575-support-reusable-…

ab7e9a6

…blocks Reusable blocks - Present block content (preview mode)

Updated gutenberg ref

04199fe

Merge pull request #3035 from wordpress-mobile/fix/flatmap-polyfill

776e5e8

Add Array.prototype.flatMap polyfill

Update gutenberg reference

130c2e4

Add release notes for single instance block support

b6c36cf

Revert change to jetpack submodule

990d121

Merge branch 'develop' into merge_release_1.45.0_to_develop

9b9e961

Merge pull request #3043 from wordpress-mobile/merge_release_1.45.0_t…

b3cf7b4

…o_develop Merge release 1.45.0 to develop

Merge branch 'develop' into dependabot/submodules/jetpack-60f41b6

42a7839

Updating gutenberg ref

2f0b63f

Merge pull request #3040 from wordpress-mobile/dependabot/submodules/…

efbbcf7

…jetpack-60f41b6 Bump jetpack from `6f07c39` to `60f41b6`

Update ref: Add block width to extra data

e96b40b

Merge develop and update gutenberg ref

6bd116c

Merge pull request #3042 from wordpress-mobile/fix/1156-more-block

73ec0c7

Add support for `"multiple": false` block types

Update ref: Improve setting blockWidth on landscape mode

7f5e0e7

Updating gutenberg ref

29221f1

Merge pull request #3052 from wordpress-mobile/fix/block-width

c7ef7ff

Correct blockWidth

updated gutenberg

ac2f99c

Merge pull request #2854 from wordpress-mobile/audio-block-I

35d0931

Audio Block - I

Update gutenberg ref

ef2fd07

Remove Reusable block action button string override

64ebb69

Update gutenberg ref

d5b51ef

Update gutenberg ref (master branch)

e79be35

Merge pull request #3067 from wordpress-mobile/fix/3061-disable-ube-r…

f6f9b35

…eusable-blocks Disable Unsupported block editor for Reusable blocks

Correct full width buttons (#3077)

6874bb2

Update release notes

a2ac05c

fluiddot added 2 commits February 3, 2021 18:26

Update gutenberg ref and bundle

8a174a3

Update gutenberg ref and bundle

5ed7f71

fluiddot mentioned this pull request Feb 4, 2021

Update Dark Mode - Test Cases - TC003 screenshot wordpress-mobile/test-cases#66

Merged

fluiddot mentioned this pull request Feb 5, 2021

Update Dark Mode - Test Cases - TC003 screenshot wordpress-mobile/test-cases#67

Closed

ceyhun approved these changes Feb 5, 2021

View reviewed changes

fluiddot added this to the 1.46 (16.7) milestone Feb 5, 2021

fluiddot merged commit ef50e91 into trunk Feb 5, 2021

fluiddot deleted the release/1.46.0 branch February 5, 2021 10:41

fluiddot mentioned this pull request Feb 5, 2021

Merge release 1.46.0 to develop #3112

Merged

2 tasks

ceyhun restored the release/1.46.0 branch February 11, 2021 15:28

fluiddot mentioned this pull request Feb 12, 2021

Test plan for 16.7 Beta version of WordPress Android app #3133

Closed

3 tasks

dcalhoun mentioned this pull request Feb 16, 2021

Release 1.47.0 #3155

Merged

3 tasks

fluiddot deleted the release/1.46.0 branch February 17, 2021 10:58

Conversation

fluiddot commented Feb 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

Release Submission Checklist

Uh oh!

fluiddot commented Feb 2, 2021

Android: Writing Flow checklist 🟡

General

Rich Text Format

Splitting and merging

Undo / Redo - Test Cases

Uh oh!

ceyhun commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Writing Flow checklist 🟡

General

Rich Text Format

Splitting and merging

Undo / Redo - Test Cases

Uh oh!

fluiddot commented Feb 2, 2021

Uh oh!

fluiddot commented Feb 2, 2021

Uh oh!

ceyhun commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fluiddot commented Feb 2, 2021

Uh oh!

ceyhun commented Feb 2, 2021

Uh oh!

chipsnyder commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Gallery - 1

Gallery - 2

Gallery - 3

Columns - 1

Columns - 2

Columns - 3

MediaText - 1

MediaText - 2

MultipleUpload - 1

Cover - 1

Editor Theme - 1

Social Icons - 1

Uh oh!

enejb commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fluiddot commented Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS & Android

Description

Next steps

Description

Next steps

Description

Next steps

Description

Next steps

Description

Next steps

Only iOS

Only Android

Description

Next steps

Description

Next steps

Uh oh!

fluiddot commented Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fluiddot commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status update

Uh oh!

fluiddot commented Feb 1, 2021 •

edited

Loading

ceyhun commented Feb 2, 2021 •

edited

Loading

ceyhun commented Feb 2, 2021 •

edited

Loading

chipsnyder commented Feb 2, 2021 •

edited

Loading

enejb commented Feb 2, 2021 •

edited

Loading

fluiddot commented Feb 3, 2021 •

edited

Loading

fluiddot commented Feb 3, 2021 •

edited

Loading

fluiddot commented Feb 4, 2021 •

edited

Loading

fluiddot commented Feb 4, 2021 •

edited

Loading