Add Array.prototype.flatMap polyfill#3035
Merged
Conversation
6 tasks
mchowning
approved these changes
Jan 21, 2021
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Tested and approved the gutenberg PR: WordPress/gutenberg#28400 (review)
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
dd7e08a to
04199fe
Compare
Contributor
Author
|
I've run the full suite of Android and iOS UI tests to verify that the original test that was failing now passes 🎊 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3034
gutenbergPR: WordPress/gutenberg#28400Description
Adds a polyfill for
Array.prototype.flatMapfunction (built-inflatMap) because it's not fully supported on Android.So far this wasn't needed because there were no references to that function but in a recent PR in
gutenbergit was introduced. It was added in the logic related to converting HTML to blocks, this functionality is used among other places in the Paste handler logic that is also used in theRichTextcomponent.To test
PR submission checklist: