[RNMobile] Add Array.prototype.flatMap polyfill#28400
Merged
Conversation
The native version doesn't fully support the built-in function flatMap so we have to add a polyfill.
|
Size Change: +270 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
2 tasks
6 tasks
Contributor
Author
We discussed this internally with @mchowning and @jsnjohnston and we all agreed on applying this solution. |
Contributor
|
Forwarding my thoughts from chat over here: I'm not too worried about this approach to polyfills in terms of maintenance. I doubt we will run into any issues there anytime soon. My only concern would be build size but that looks fine too. I was also looking more into All and all this looks like the best approach to me, nice work @fluiddot ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3035Description
Adds a polyfill for
Array.prototype.flatMapfunction (built-inflatMap) because the native version doesn't fully support it.So far this wasn't needed because there were no references in the native version to that function but in a recent PR it was introduced in the logic related to converting HTML to blocks.
How has this been tested?
This is a fix related to the issue "Pasting a text with text styles applied generates a exception" so the same steps can be used for testing it:
Screenshots
Video capture of copy/paste text with text styles:
copy-paste-text-android.mp4
Types of changes
Bug fix
Checklist: