Skip to content

Correct full width buttons#3077

Merged
lukewalczak merged 3 commits intodevelopfrom
fix-full-width-button
Feb 1, 2021
Merged

Correct full width buttons#3077
lukewalczak merged 3 commits intodevelopfrom
fix-full-width-button

Conversation

@lukewalczak
Copy link
Copy Markdown
Contributor

@lukewalczak lukewalczak commented Feb 1, 2021

Fixes the problem with wrongly displayed Buttons on full-width.

gutenberg pr: WordPress/gutenberg#28523

To test:

  1. Do sanity testing for Buttons
  2. Add Buttons block
  3. Fill it with some characters
  4. Change the alignment to wide width
  5. Type some characters again and take the whole available space
  6. Rotate the device
  7. Observe if buttons fit in the screen
  8. Change the alignment to full width
  9. Again observe if buttons fit in the screen

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 1, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@lukewalczak lukewalczak merged commit 6874bb2 into develop Feb 1, 2021
@lukewalczak lukewalczak deleted the fix-full-width-button branch February 1, 2021 12:18
@fluiddot fluiddot mentioned this pull request Feb 1, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants