Move custom indicator to be rendered above the colors#3098
Merged
lukewalczak merged 2 commits intodevelopfrom Feb 4, 2021
Merged
Move custom indicator to be rendered above the colors#3098lukewalczak merged 2 commits intodevelopfrom
lukewalczak merged 2 commits intodevelopfrom
Conversation
…avoid the crash on Android
fluiddot
approved these changes
Feb 3, 2021
Contributor
fluiddot
left a comment
There was a problem hiding this comment.
Tested and approved via WordPress/gutenberg#28698 (review).
Contributor
|
@lukewalczak I think this PR is ready to be merged, although first we should resolve the conflict in the |
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3097
To test:
Background Coloroptions.Expect app mustn't crash
PR submission checklist: