Reusable blocks - Present block content (preview mode)#2953
Merged
Reusable blocks - Present block content (preview mode)#2953
Conversation
6 tasks
08354b8 to
e3fd9be
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Contributor
Author
|
|
2 tasks
a95092a to
8f44856
Compare
Contributor
|
Just removing myself as reviewer since I won't be around for the next two weeks. |
8f44856 to
4a002f2
Compare
42 tasks
ceyhun
approved these changes
Jan 19, 2021
Contributor
ceyhun
left a comment
There was a problem hiding this comment.
Reviewed via: WordPress/gutenberg#25265. We can merge this after the gutenberg PR is merged and the ref is updated.
848fba1 to
5b392cd
Compare
Contributor
Author
|
Gutenberg submodule updated, now it's pointing to the merge commit of the Gutenberg PR in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg PR-> WordPress/gutenberg#25265Second part (adding Reusable blocks to the inserter menu):
Gutenberg PR-> WordPress/gutenberg#25383Gutenberg-mobile PR-> #2644Related to #2575
This PR is the first part of the issue Add Support to Insert Existing Reusable Blocks from the Editor.
The scope of this issue is limited to add Reusable blocks to the inserter menu, however due to the need of registering the Reusable block type (core/block), I also had to add support for presenting it in the editor.
The edition support will be added in this issue, so for now this PR only provides the preview mode of this type of block.
To test:
Check test steps in Gutenberg PR WordPress/gutenberg#25265
PR submission checklist: