Skip to content

Correct blockWidth#3079

Merged
lukewalczak merged 2 commits intodevelopfrom
block-width-fix
Feb 1, 2021
Merged

Correct blockWidth#3079
lukewalczak merged 2 commits intodevelopfrom
block-width-fix

Conversation

@lukewalczak
Copy link
Copy Markdown
Contributor

@lukewalczak lukewalczak commented Feb 1, 2021

Fixes the issue with missing cog button in nested Button block

gb pr: WordPress/gutenberg#28635

To test:

  1. Open an app
  2. Add Buttons block
  3. Save a post
  4. Open it again
  5. Focus the Button within Buttons
  6. Expect settings buttons is visible (cog)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak self-assigned this Feb 1, 2021
@lukewalczak lukewalczak added this to the 1.46 (16.7) milestone Feb 1, 2021
@lukewalczak lukewalczak mentioned this pull request Feb 1, 2021
Merged
6 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 1, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@lukewalczak lukewalczak merged commit edff206 into develop Feb 1, 2021
@lukewalczak lukewalczak deleted the block-width-fix branch February 1, 2021 16:04
@ceyhun ceyhun mentioned this pull request Feb 1, 2021
Merged
2 tasks
@fluiddot fluiddot mentioned this pull request Feb 2, 2021
Merged
3 tasks
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dratwas dratwas dratwas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukewalczak lukewalczak

Labels

None yet

Projects

None yet

Milestone

1.46 (16.7)

Development

Successfully merging this pull request may close these issues.

2 participants

@lukewalczak @dratwas