Skip to content

Release 1.38.0#2677

Merged
cameronvoell merged 136 commits intotrunkfrom
release/1.38.0
Oct 2, 2020
Merged

Release 1.38.0#2677
cameronvoell merged 136 commits intotrunkfrom
release/1.38.0

Conversation

@cameronvoell
Copy link
Copy Markdown
Contributor

@cameronvoell cameronvoell commented Sep 28, 2020 •
edited
Loading

Release for Gutenberg Mobile 1.38.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Aztec Android:

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Aztec dependencies are pointing to a stable release.
    • iOS: Aztec dependencies match in RNTAztecView.podspec and gutenberg/packages/react-native-aztec/RNTAztecView.podspec.
  • Gutenberg 'Podfile.lock' inside 'gutenberg/package/react-native-editor/ios/' is updated to the release number.
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

ceyhun and others added 30 commits August 18, 2020 14:33
@ceyhun
Fix android remote name
05e33f5
@ceyhun
Fix PR formatting
9383b8a
@ceyhun
Do not try to commit string update result if there are no changes
2ae1364
@ceyhun
Update gutenberg-mobile submodules after checkout to prevent git stat…
80ccd7e 
…us changes
@chipsnyder
Add supported-blocks.json and expose it as part of the Pod
ffb8445
@chipsnyder
Add reminder documentation on where to update the file
709b5f6
@chipsnyder
Bump gutenberg version
4c6d340
@chipsnyder
Update pod spec to not overwrite resources
0792ea1
@chipsnyder
Merge remote-tracking branch 'origin/develop' into issue/2444-support…
7ee68b4 
…edBlocks_v2
@marecar3
update gb reference
0516432
@marecar3
Update release notes
8ee1539
@marecar3
Update gb reference
e62bf39
@etoledom
Testing UIStringContext
0839f3b
@etoledom
Adding custom string to be shown on missing block alert
95a79a4
@etoledom
Update gutenberg ref
f3fb203
@chipsnyder
Move pullquote to be common block
13a23ab
@marecar3
Update gb reference
303b2a8
@marecar3
Merge branch 'develop' into improvement/2567-Increase_tap_target_of_p…
3fb38ef 
…rimary_action_on_unsupported_blocks
@marecar3
Update release notes version
8132f0d
@ceyhun
Add set -e option
53a9f5d
@marecar3
Update gb reference
9d9a30a
@marecar3
Merge branch 'develop' into improvement/2567-Increase_tap_target_of_p…
0bce15b 
…rimary_action_on_unsupported_blocks
@marecar3
Update gb reference
324a165
@lukewalczak
Correct colors when switching between modes (#2618)
c98626e
@ceyhun
Recognize both gb "tag" and "commit" in Podfile
c236846
@marecar3
Update gb reference
f2944e4
@marecar3
Merge branch 'develop' into improvement/2567-Increase_tap_target_of_p…
575e25f 
…rimary_action_on_unsupported_blocks
@marecar3
Merge pull request #2608 from wordpress-mobile/improvement/2567-Incre…
b16f6df 
…ase_tap_target_of_primary_action_on_unsupported_blocks

Increase tap-target of primary action on unsupported blocks
@ceyhun
Update README.md
eb7a9f9
@antonis
Update Gutenberg ref
720032f
This was referenced Sep 28, 2020
Merged
Merged
Merged
@cameronvoell cameronvoell requested a review from ceyhun September 28, 2020 22:55
@cameronvoell cameronvoell marked this pull request as ready for review September 29, 2020 06:48
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Sep 29, 2020 •
edited
Loading

Testing with WPiOS

Gallery-2

  • Gallery block - Insert image from device (failing) - steps
  • Gallery block - Insert image from device (cancel) - steps

Gallery-4

  • Gallery block - Settings: Link to - steps
  • Gallery block - Settings: Column number - steps
  • Gallery block - Settings: Crop images - steps

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText-3

  • Media Text block - Insert video from device (failing) - steps
  • Media Text block - Close/Re-open post with an ongoing video upload - steps

MediaText-4

  • Media Text block - Media & Text alignment - steps
  • Media Text block - Vertical alignment - steps

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover-2

  • Cover - Add Video Background from WordPress Media library - steps
  • Cover - Replace media - steps
  • Cover - Gradient background is rendered properly - steps
  • Cover - Gradient overlay is rendered properly - steps

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - steps
  • Ghost placeholder is visible when no icon is active - steps
  • Social icon forwarding to the link - steps

@dratwas
Copy link
Copy Markdown
Contributor

dratwas commented Sep 29, 2020 •
edited
Loading

Testing with WPAndroid

DarkMode-2

  • Spacer block - Dark mode - steps
  • Buttons block - Dark mode - steps
  • Group - Dark mode - steps
  • Columns - Dark mode - steps

Group-2

  • Group - Navigation up button works as expected - steps
  • Group - Navigation down works according to parent-first approach - steps
  • Group - Cross navigation between blocks works as expected - steps
  • Group - Ungroup button works as expected - steps
  • Group - Check if in DarkMode all components gets proper colors - steps
  • Group - Check if nested Placeholder block can be replaced - steps

Spacer-2

  • Spacer block - Settings: Available height range is correct - steps
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps
  • Spacer block - Spacer in horizontal layout works as expected - steps

Button-4

  • Buttons block - Render custom text color - steps
  • Buttons block - Render custom background color - steps
  • Buttons block - Render gradient background color - steps
  • Buttons block - Check if selection / caret color matches font color - steps
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps

Button-5

  • Buttons block - Edit text styles - steps
  • Buttons block - Render theme colors - steps
  • Buttons block - Settings: Change Button border radius - steps

Button-7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps
  • Buttons block - Toolbar link button is active when Button has link - steps

Editor Theme-2

  • Custom Gradients - Check that custom gradients load in the editor - steps
  • Offline Support - steps

Color Settings-2

  • Pressing color swatch - steps
  • Customize gradient color - steps
  • Custom color picker - steps

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 29, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@pinarol pinarol mentioned this pull request Sep 29, 2020
Closed
@lukewalczak
Copy link
Copy Markdown
Contributor

lukewalczak commented Sep 30, 2020 •
edited
Loading

I observed the crash within the cover block when trying to scroll the color palette on the cover placeholder.

Steps to reproduce it:

  1. Open a post
  2. Add Cover block
  3. Try to scroll the color palette on the placeholder
  4. Observe the crash

cc: @antonis @pinarol

I opened the issue to track it: #2682

PR fixing that: WordPress/gutenberg#25734

@ceyhun
Copy link
Copy Markdown
Contributor

ceyhun commented Sep 30, 2020

Tested with WPiOS Build 35590 on iPhone 11 Pro with iOS 14

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

I encountered an issue with the first test case of undo/redo where at the last step I couldn't remove again the last block by redoing. I could not reproduce this issue again so marked it as ✅ for now.

@cameronvoell
Copy link
Copy Markdown
Contributor Author

cameronvoell commented Sep 30, 2020 •
edited
Loading

Android Tests, Samsung Galaxy S10+, Android 10

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

ceyhun
ceyhun approved these changes Oct 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested new changes as well, LGTM!

@cameronvoell
Update RELEASE-NOTES.txt
021da00 
Added release note for accessibility mode improvement
@cameronvoell
Update bundles
8cfac07
@cameronvoell cameronvoell merged commit 2ad0858 into trunk Oct 2, 2020
@cameronvoell cameronvoell deleted the release/1.38.0 branch October 2, 2020 16:20
@cameronvoell cameronvoell mentioned this pull request Oct 5, 2020
Merged
2 tasks
@designsimply
Copy link
Copy Markdown
Contributor

designsimply commented Oct 5, 2020

I found this in the release notes:

Block Editor: On Jetpack connected sites, Unsupported Block Editor can be enabled via enabling Jetpack SSO setting directly from within the missing block alert.

I searched and found wordpress-mobile/WordPress-Android#12606 but I was wondering why that PR (or a similar one) wasn't mentioned in the release notes?

The best testing steps look like they're in WordPress/gutenberg#24476 but could you also let me know what else would be ideal to test during 15.9 beta testing or is that the best PR to reference?

I have the same question for wordpress-mobile/WordPress-Android#12990.

Note: only the Jetpack SSO part is mentioned in the release notes for 15.9, should the Unsupported Block Editor itself also be called out? What would you like to tell users about it? Please see p2JRYi-53L-p2.

@designsimply
Copy link
Copy Markdown
Contributor

designsimply commented Oct 5, 2020

Okay. Gah. Perhaps ignore most of that last message! I found the proper link to wordpress-mobile/WordPress-Android#13011 in the RELEASE-NOTES.txt file while I was looking at p2JRYi-53L-p2 before (where they are missing). 😬

The final release notes still might need to be modified at p2JRYi-53L-p2 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ceyhun ceyhun ceyhun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.