[Gutenberg] Account for the end of buffer marker#928
Merged
Conversation
khaykov
approved these changes
Sep 17, 2020
Contributor
khaykov
left a comment
There was a problem hiding this comment.
I confirmed the issue and that the fix works! Thanks for the fix 👍
5 tasks
This was referenced Dec 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
wordpress-mobile/gutenberg-mobile#1663
wordpress-mobile/gutenberg-mobile#1524
When deleting text in the Heading block the end of buffer marker prevents the
handleBackspaceAndEnterevent from firing resulting in weird behavior like the placeholder not showing up. This also affects formatting updates.To resolve this I now account for that character in
emptyEditTextBackspaceDetectorcheck these changes will allow theHeading block
Expect to see the placeholder text return after the last character is deleted
Before
After
Paragraph block
Expect to see the placeholder text return after the last character is deleted
Before
After
Review
@khaykov I think you were the last one to work in this area if you have time to review if not just let me know and I can ask someone working on Gutenberg to review.
Make sure strings will be translated:
strings.xmlas a part of the integration PR.