Improve AztecWrapper RN talkback support#2630
Merged
jd-alexander merged 7 commits intodevelopfrom Sep 24, 2020
Merged
Conversation
6 tasks
…aztec_wrapper_talkback_support
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #918
Related PRs
Gutenberg PR WordPress/gutenberg#25384
Aztec Android PR wordpress-mobile/AztecEditor-Android#927
Description
Currently the RichText will focus automatically without needing double tapping. This was taking place due to the
AccessibilityDelegateinAztecrequesting focus on hover, so that behavior was removed. This PR, resolves this by utilizing the mentioned fix within Aztec along with enabling theRichTextcomponent via theReactAztecManagerso that thedouble-tap to activatebehavior becomes active.Testing
Follow testing instructions here WordPress/gutenberg#25384
PR submission checklist: